Commit 5a25b999 authored by zmo's avatar zmo Committed by Commit bot

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001...

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)

Reason for revert:
It was temporary and no longer needed.

Original issue's description:
> Add logs to debug a flakiness on GPU Mac bots.
>
> This is temporary and will be removed after we pin down the issue.
>
> BUG=424024
> TEST=
> R=kbr@chromium.org
> TBR=dgozman@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> Cr-Commit-Position: refs/heads/master@{#302371}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/698353002

Cr-Commit-Position: refs/heads/master@{#302669}
parent eb0998c9
...@@ -163,14 +163,12 @@ class DevToolsHttpHandlerImpl::BrowserTarget { ...@@ -163,14 +163,12 @@ class DevToolsHttpHandlerImpl::BrowserTarget {
tracing_handler_(new devtools::tracing::TracingHandler( tracing_handler_(new devtools::tracing::TracingHandler(
devtools::tracing::TracingHandler::Browser)), devtools::tracing::TracingHandler::Browser)),
protocol_handler_(new DevToolsProtocolHandlerImpl()) { protocol_handler_(new DevToolsProtocolHandlerImpl()) {
VLOG(2) << "BrowserTarget::BrowserTarget()";
protocol_handler_->SetNotifier( protocol_handler_->SetNotifier(
base::Bind(&BrowserTarget::Respond, base::Unretained(this))); base::Bind(&BrowserTarget::Respond, base::Unretained(this)));
protocol_handler_->SetTracingHandler(tracing_handler_.get()); protocol_handler_->SetTracingHandler(tracing_handler_.get());
} }
~BrowserTarget() { ~BrowserTarget() {
VLOG(2) << "BrowserTarget::~BrowserTarget()";
STLDeleteElements(&handlers_); STLDeleteElements(&handlers_);
} }
...@@ -702,7 +700,6 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI( ...@@ -702,7 +700,6 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(
std::string browser_prefix = "/devtools/browser"; std::string browser_prefix = "/devtools/browser";
size_t browser_pos = request.path.find(browser_prefix); size_t browser_pos = request.path.find(browser_prefix);
if (browser_pos == 0) { if (browser_pos == 0) {
VLOG(2) << "OnWebSocketRequestUI: new BrowserTarget";
BrowserTarget* browser_target = new BrowserTarget( BrowserTarget* browser_target = new BrowserTarget(
thread_->message_loop(), server_.get(), connection_id); thread_->message_loop(), server_.get(), connection_id);
browser_target->RegisterHandler( browser_target->RegisterHandler(
......
...@@ -101,8 +101,6 @@ DevToolsSystemInfoHandler::~DevToolsSystemInfoHandler() { ...@@ -101,8 +101,6 @@ DevToolsSystemInfoHandler::~DevToolsSystemInfoHandler() {
scoped_refptr<DevToolsProtocol::Response> scoped_refptr<DevToolsProtocol::Response>
DevToolsSystemInfoHandler::OnGetInfo( DevToolsSystemInfoHandler::OnGetInfo(
scoped_refptr<DevToolsProtocol::Command> command) { scoped_refptr<DevToolsProtocol::Command> command) {
VLOG(2) << "DevToolsSystemInfoHandler::OnGetInfo() : BEGIN";
gpu::GPUInfo gpu_info = GpuDataManagerImpl::GetInstance()->GetGPUInfo(); gpu::GPUInfo gpu_info = GpuDataManagerImpl::GetInstance()->GetGPUInfo();
base::DictionaryValue* gpu_dict = new base::DictionaryValue; base::DictionaryValue* gpu_dict = new base::DictionaryValue;
...@@ -126,8 +124,6 @@ DevToolsSystemInfoHandler::OnGetInfo( ...@@ -126,8 +124,6 @@ DevToolsSystemInfoHandler::OnGetInfo(
system_dict->SetString(kModelName, gpu_info.machine_model_name); system_dict->SetString(kModelName, gpu_info.machine_model_name);
system_dict->SetString(kModelVersion, gpu_info.machine_model_version); system_dict->SetString(kModelVersion, gpu_info.machine_model_version);
system_dict->Set(kGPU, gpu_dict); system_dict->Set(kGPU, gpu_dict);
VLOG(2) << "DevToolsSystemInfoHandler::OnGetInfo() : END";
return command->SuccessResponse(system_dict); return command->SuccessResponse(system_dict);
} }
......
...@@ -301,7 +301,6 @@ unsigned int GpuDataManagerImplPrivate::GetDisplayCount() const { ...@@ -301,7 +301,6 @@ unsigned int GpuDataManagerImplPrivate::GetDisplayCount() const {
} }
gpu::GPUInfo GpuDataManagerImplPrivate::GetGPUInfo() const { gpu::GPUInfo GpuDataManagerImplPrivate::GetGPUInfo() const {
VLOG(2) << "GpuDataManagerImplPrivate::GetGPUInfo()";
return gpu_info_; return gpu_info_;
} }
...@@ -905,7 +904,6 @@ GpuDataManagerImplPrivate::GpuDataManagerImplPrivate( ...@@ -905,7 +904,6 @@ GpuDataManagerImplPrivate::GpuDataManagerImplPrivate(
display_count_(0), display_count_(0),
gpu_process_accessible_(true), gpu_process_accessible_(true),
finalized_(false) { finalized_(false) {
VLOG(2) << "GpuDataManagerImplPrivate::GpuDataManagerImplPrivate()";
DCHECK(owner_); DCHECK(owner_);
const base::CommandLine* command_line = const base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess(); base::CommandLine::ForCurrentProcess();
...@@ -924,7 +922,6 @@ GpuDataManagerImplPrivate::GpuDataManagerImplPrivate( ...@@ -924,7 +922,6 @@ GpuDataManagerImplPrivate::GpuDataManagerImplPrivate(
} }
GpuDataManagerImplPrivate::~GpuDataManagerImplPrivate() { GpuDataManagerImplPrivate::~GpuDataManagerImplPrivate() {
VLOG(2) << "GpuDataManagerImplPrivate::~GpuDataManagerImplPrivate()";
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
CGDisplayRemoveReconfigurationCallback(DisplayReconfigCallback, owner_); CGDisplayRemoveReconfigurationCallback(DisplayReconfigCallback, owner_);
#endif #endif
...@@ -934,8 +931,6 @@ void GpuDataManagerImplPrivate::InitializeImpl( ...@@ -934,8 +931,6 @@ void GpuDataManagerImplPrivate::InitializeImpl(
const std::string& gpu_blacklist_json, const std::string& gpu_blacklist_json,
const std::string& gpu_driver_bug_list_json, const std::string& gpu_driver_bug_list_json,
const gpu::GPUInfo& gpu_info) { const gpu::GPUInfo& gpu_info) {
VLOG(2) << "GpuDataManagerImplPrivate::InitializeImpl()";
const bool log_gpu_control_list_decisions = const bool log_gpu_control_list_decisions =
base::CommandLine::ForCurrentProcess()->HasSwitch( base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kLogGpuControlListDecisions); switches::kLogGpuControlListDecisions);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment