Commit 5a47c761 authored by dpranke's avatar dpranke Committed by Commit bot

Fix the GN upload (build) flags to not depend on GN.

This changes the GN args we use on the linux_chromium_gn_upload
bot to not require a runtime dependency on GN.

This CL also deletes the old ntries for the 32-bit and 64-bit
upload bots (we just do 64-bit now, using the newer builder named
linux_chromium_gn_upload).

TBR=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1168743003

Cr-Commit-Position: refs/heads/master@{#333140}
parent a7815e75
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
'dev_gyp_debug': ['gyp', 'debug', 'shared', 'full_symbols'], 'dev_gyp_debug': ['gyp', 'debug', 'shared', 'full_symbols'],
'dev_gn_release': ['gn', 'release', 'shared'], 'dev_gn_release': ['gn', 'release', 'shared'],
'dev_gyp_release': ['gyp', 'release', 'shared'], 'dev_gyp_release': ['gyp', 'release', 'shared'],
'gn_linux_upload': ['gn_linux_upload'],
'gn_release_bot': ['gn', 'release_bot'], 'gn_release_bot': ['gn', 'release_bot'],
'gn_release_bot_x86': ['gn', 'release_bot', 'x86'], 'gn_release_bot_x86': ['gn', 'release_bot', 'x86'],
'gn_release_trybot': ['gn', 'release_trybot'], 'gn_release_trybot': ['gn', 'release_trybot'],
...@@ -89,6 +90,16 @@ ...@@ -89,6 +90,16 @@
'gyp_defines': 'fastbuild=0', 'gyp_defines': 'fastbuild=0',
}, },
'gn_linux_upload': {
'type': 'gn',
# We don't want to require a runtime dependency on glib in the
# GN binary; ideally we could just turn glib off, but that doesn't
# actually work, so we need to pretend to be doing an ozone build
# in order for the flag to actually take effect.
'gn_args': 'use_ozone=true use_glib=false',
},
'gn': {'type': 'gn'}, 'gn': {'type': 'gn'},
'goma': { 'goma': {
...@@ -194,9 +205,7 @@ ...@@ -194,9 +205,7 @@
'linux_chromium_gn_chromeos_dbg': 'chromeos_gn_debug_bot', 'linux_chromium_gn_chromeos_dbg': 'chromeos_gn_debug_bot',
'linux_chromium_gn_dbg': 'gn_debug_bot', 'linux_chromium_gn_dbg': 'gn_debug_bot',
'linux_chromium_gn_rel': 'gn_release_trybot', 'linux_chromium_gn_rel': 'gn_release_trybot',
'linux_chromium_gn_upload': 'gn_release_bot', 'linux_chromium_gn_upload': 'gn_linux_upload',
'linux_chromium_gn_upload_x64': 'gn_release_bot', # TODO(dpranke): Remove me.
'linux_chromium_gn_upload_x86': 'gn_release_bot_x86', # TODO(dpranke): Remove me.
}, },
'tryserver.chromium.mac': { 'tryserver.chromium.mac': {
'mac_chromium_gn_dbg': 'gn_debug_static_bot', 'mac_chromium_gn_dbg': 'gn_debug_static_bot',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment