Commit 5a4ce1c0 authored by Kamila's avatar Kamila Committed by Commit Bot

RecordPermissionActionUkm should record stable content setting type ids


Bug: 1046341
Change-Id: Ia45fa0be8876e043bd5e9922da6f61995c7d3fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030884
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737805}
parent e1649e5f
...@@ -275,10 +275,17 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness { ...@@ -275,10 +275,17 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
auto* entry = entries.front(); auto* entry = entries.front();
ukm_recorder.ExpectEntrySourceHasUrl(entry, url); ukm_recorder.ExpectEntrySourceHasUrl(entry, url);
size_t num_values = 0;
EXPECT_NE(ContentSettingTypeToHistogramValue(content_settings_type,
&num_values),
-1);
EXPECT_EQ(*ukm_recorder.GetEntryMetric(entry, "Source"), EXPECT_EQ(*ukm_recorder.GetEntryMetric(entry, "Source"),
static_cast<int64_t>(PermissionSourceUI::PROMPT)); static_cast<int64_t>(PermissionSourceUI::PROMPT));
EXPECT_EQ(*ukm_recorder.GetEntryMetric(entry, "PermissionType"), EXPECT_EQ(*ukm_recorder.GetEntryMetric(entry, "PermissionType"),
static_cast<int64_t>(content_settings_type)); static_cast<int64_t>(ContentSettingTypeToHistogramValue(
content_settings_type, &num_values)));
EXPECT_EQ(*ukm_recorder.GetEntryMetric(entry, "Action"), EXPECT_EQ(*ukm_recorder.GetEntryMetric(entry, "Action"),
static_cast<int64_t>(action.value())); static_cast<int64_t>(action.value()));
......
...@@ -148,10 +148,12 @@ void RecordPermissionActionUkm( ...@@ -148,10 +148,12 @@ void RecordPermissionActionUkm(
if (!source_id.has_value()) if (!source_id.has_value())
return; return;
size_t num_values = 0;
ukm::builders::Permission(source_id.value()) ukm::builders::Permission(source_id.value())
.SetAction(static_cast<int64_t>(action)) .SetAction(static_cast<int64_t>(action))
.SetGesture(static_cast<int64_t>(gesture_type)) .SetGesture(static_cast<int64_t>(gesture_type))
.SetPermissionType(static_cast<int64_t>(permission)) .SetPermissionType(static_cast<int64_t>(
ContentSettingTypeToHistogramValue(permission, &num_values)))
.SetPriorDismissals(std::min(kPriorCountCap, dismiss_count)) .SetPriorDismissals(std::min(kPriorCountCap, dismiss_count))
.SetPriorIgnores(std::min(kPriorCountCap, ignore_count)) .SetPriorIgnores(std::min(kPriorCountCap, ignore_count))
.SetSource(static_cast<int64_t>(source_ui)) .SetSource(static_cast<int64_t>(source_ui))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment