Commit 5a557cdb authored by Tommy Steimel's avatar Tommy Steimel Committed by Commit Bot

Kaleidoscope: Remove deprecated method from data provider

This CL is a followup of crrev.com/c/2365314 which removes the code
that is deprecated by that CL. There is a chrome-internal CL that must
land after that CL and before this CL in order to avoid a broken state.

Bug: b:154517281
Change-Id: I21e0363a0744600b8d91857d53d435841b17145d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367934
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: default avatarAlex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801035}
parent d6531e24
...@@ -159,11 +159,6 @@ void KaleidoscopeDataProviderImpl::GetShouldShowFirstRunExperience( ...@@ -159,11 +159,6 @@ void KaleidoscopeDataProviderImpl::GetShouldShowFirstRunExperience(
std::move(cb).Run(false); std::move(cb).Run(false);
} }
void KaleidoscopeDataProviderImpl::SetFirstRunExperienceCompleted() {
SetFirstRunExperienceStep(
media::mojom::KaleidoscopeFirstRunExperienceStep::kCompleted);
}
void KaleidoscopeDataProviderImpl::SetFirstRunExperienceStep( void KaleidoscopeDataProviderImpl::SetFirstRunExperienceStep(
media::mojom::KaleidoscopeFirstRunExperienceStep step) { media::mojom::KaleidoscopeFirstRunExperienceStep step) {
if (metrics_recorder_) if (metrics_recorder_)
......
...@@ -51,7 +51,6 @@ class KaleidoscopeDataProviderImpl ...@@ -51,7 +51,6 @@ class KaleidoscopeDataProviderImpl
void GetCredentials(GetCredentialsCallback cb) override; void GetCredentials(GetCredentialsCallback cb) override;
void GetShouldShowFirstRunExperience( void GetShouldShowFirstRunExperience(
GetShouldShowFirstRunExperienceCallback cb) override; GetShouldShowFirstRunExperienceCallback cb) override;
void SetFirstRunExperienceCompleted() override;
void SetFirstRunExperienceStep( void SetFirstRunExperienceStep(
media::mojom::KaleidoscopeFirstRunExperienceStep step) override; media::mojom::KaleidoscopeFirstRunExperienceStep step) override;
void GetAllMediaFeeds(GetAllMediaFeedsCallback cb) override; void GetAllMediaFeeds(GetAllMediaFeedsCallback cb) override;
......
...@@ -61,10 +61,6 @@ interface KaleidoscopeDataProvider { ...@@ -61,10 +61,6 @@ interface KaleidoscopeDataProvider {
// Returns true if the first run experience should be shown. // Returns true if the first run experience should be shown.
GetShouldShowFirstRunExperience() => (bool should_show_first_run); GetShouldShowFirstRunExperience() => (bool should_show_first_run);
// Called when the user successfully completes the first run experience.
// DEPRECATED: will be removed as soon as a private-side CL also lands.
SetFirstRunExperienceCompleted();
// While the user is on the First Run Experience, this will be called each // While the user is on the First Run Experience, this will be called each
// time they move onto a different step. Used to set prefs and record metrics // time they move onto a different step. Used to set prefs and record metrics
// on what step the user stopped at. // on what step the user stopped at.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment