Commit 5a84201c authored by Yoichi Osato's avatar Yoichi Osato Committed by Chromium LUCI CQ

Disable flaky DetachToBrowserTabDragControllerTest tests on win.

This CL disables DragMultipleTabsRightIntoGroup and
DragAllToSeparateWindow on windows.

TBR=sky@chromium.org

Bug: 1164561, 1128774
Change-Id: I49c825f1950af449e765f0a3f2a1918b1ddfb3a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623570Reviewed-by: default avatarYoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842362}
parent a1bc8384
......@@ -951,8 +951,15 @@ IN_PROC_BROWSER_TEST_P(DetachToBrowserTabDragControllerTest,
// tabs joining the same group as the tab in the second position. Then dragging
// the tabs over two to the right will result in the tabs joining the same group
// as the last tab.
// Flaky on windows. http://crbug.com/1164561
#if defined(OS_WIN)
#define MAYBE_DragMultipleTabsRightIntoGroup \
DISABLED_DragMultipleTabsRightIntoGroup
#else
#define MAYBE_DragMultipleTabsRightIntoGroup DragMultipleTabsRightIntoGroup
#endif
IN_PROC_BROWSER_TEST_P(DetachToBrowserTabDragControllerTest,
DragMultipleTabsRightIntoGroup) {
MAYBE_DragMultipleTabsRightIntoGroup) {
TabStrip* tab_strip = GetTabStripForBrowser(browser());
TabStripModel* model = browser()->tab_strip_model();
TabGroupModel* group_model = model->group_model();
......@@ -2052,7 +2059,8 @@ void DragAllToSeparateWindowStep2(DetachToBrowserTabDragControllerTest* test,
} // namespace
#if defined(OS_MAC) /* && defined(ARCH_CPU_ARM64) */
// Flaky. http://crbug.com/1128774
#if defined(OS_MAC) || defined(OS_WIN)
// Bulk-disabled for arm64 bot stabilization: https://crbug.com/1154345
// These were flaking on all macs, so commented out ARCH_ above for
// crbug.com/1160917 too.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment