Commit 5aa36a85 authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

CodeGen: Fix minor compile errors in dictionary

Bug: 839389
Change-Id: I55b0dc09f7de94760e7690e2b4943846446eb901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026918Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736283}
parent e1a551ea
...@@ -347,7 +347,7 @@ def make_fill_dict_members_def(cg_context): ...@@ -347,7 +347,7 @@ def make_fill_dict_members_def(cg_context):
if len(required_own_members) > 0: if len(required_own_members) > 0:
check_required_members_node = T("""\ check_required_members_node = T("""\
if (v8_value->IsNullOrUndefined()) { if (v8_value->IsNullOrUndefined()) {
exception_state.ThrowError(ExceptionMessages::FailedToConstruct( exception_state.ThrowTypeError(ExceptionMessages::FailedToConstruct(
"${dictionary.identifier}", "${dictionary.identifier}",
"has required members, but null/undefined was passed.")); "has required members, but null/undefined was passed."));
return; return;
...@@ -446,7 +446,7 @@ def make_fill_own_dict_member(key_index, member): ...@@ -446,7 +446,7 @@ def make_fill_own_dict_member(key_index, member):
pattern = """ pattern = """
if (!v8_dictionary->Get(${current_context}, member_names[{_1}].Get(${isolate})) if (!v8_dictionary->Get(${current_context}, member_names[{_1}].Get(${isolate}))
.ToLocal(&v8_memer)) {{ .ToLocal(&v8_value)) {{
${exception_state}.RethrowV8Exception(try_block.Exception()); ${exception_state}.RethrowV8Exception(try_block.Exception());
return; return;
}}""" }}"""
...@@ -543,7 +543,7 @@ static ${class_name}* Create() { ...@@ -543,7 +543,7 @@ static ${class_name}* Create() {
} }
static ${class_name}* Create( static ${class_name}* Create(
v8::Isolate* isolate, v8::Isolate* isolate,
v8::Local<v8::value> v8_value, v8::Local<v8::Value> v8_value,
ExceptionState& exception_state); ExceptionState& exception_state);
${class_name}() = default; ${class_name}() = default;
~${class_name}() = default; ~${class_name}() = default;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment