Commit 5ab6138e authored by Yoshifumi Inoue's avatar Yoshifumi Inoue Committed by Chromium LUCI CQ

Utilize EphemeralRange::IsCollapsed() in ComputeAdjustedSelection()

This patch makes |ComputeAdjustedSelection()| to utilize |IsCollapsed()|
of |EphemeralRange|[1] to simplify source code for improving code health.

Note: This patch doesn't change behavior.

[1] http://crrev.com/c/2550834: [editing] Ranges with equivalent positions
should be collapsed

Change-Id: Iab464fafb0f02f90d346bc1cbc0a2734d6744138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567146
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832722}
parent 9e5a3886
...@@ -43,10 +43,9 @@ template <typename Strategy> ...@@ -43,10 +43,9 @@ template <typename Strategy>
SelectionTemplate<Strategy> ComputeAdjustedSelection( SelectionTemplate<Strategy> ComputeAdjustedSelection(
const SelectionTemplate<Strategy> selection, const SelectionTemplate<Strategy> selection,
const EphemeralRangeTemplate<Strategy>& range) { const EphemeralRangeTemplate<Strategy>& range) {
if (range.StartPosition().CompareTo(range.EndPosition()) == 0) { if (range.IsCollapsed()) {
return typename SelectionTemplate<Strategy>::Builder() return typename SelectionTemplate<Strategy>::Builder()
.Collapse(selection.IsBaseFirst() ? range.StartPosition() .Collapse(range.StartPosition())
: range.EndPosition())
.Build(); .Build();
} }
if (selection.IsBaseFirst()) { if (selection.IsBaseFirst()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment