Commit 5ae0ee4d authored by haibinlu's avatar haibinlu Committed by Commit bot

so that users does not have to specify command line arguments.

It generates logs:

V/chromium(22041): [VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=61379>
V/chromium(22041): [VERBOSE1:blimp_connection.cc(66)] Sending <BlimpMessage type=PROTOCOL_CONTROL subtype=CHECKPOINT_ACK checkpoint_id=20 byte_size=15>

BUG=596796

Review URL: https://codereview.chromium.org/1841183002

Cr-Commit-Position: refs/heads/master@{#383840}
parent f53fdccf
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "blimp/client/app/blimp_startup.h" #include "blimp/client/app/blimp_startup.h"
#include "base/command_line.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/lazy_instance.h" #include "base/lazy_instance.h"
#include "base/logging.h" #include "base/logging.h"
...@@ -33,6 +34,13 @@ namespace blimp { ...@@ -33,6 +34,13 @@ namespace blimp {
namespace client { namespace client {
void InitializeLogging() { void InitializeLogging() {
// TODO(haibinlu): Remove this before release.
// Enables a few verbose log by default.
if (!base::CommandLine::ForCurrentProcess()->HasSwitch("vmodule")) {
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
"vmodule", "blimp_message_pump=1, blimp_connection=1");
}
logging::LoggingSettings settings; logging::LoggingSettings settings;
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG; settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
......
...@@ -63,7 +63,7 @@ void BlimpMessageSender::ProcessMessage( ...@@ -63,7 +63,7 @@ void BlimpMessageSender::ProcessMessage(
scoped_ptr<BlimpMessage> message, scoped_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) { const net::CompletionCallback& callback) {
DCHECK(error_observer_); DCHECK(error_observer_);
DVLOG(2) << "Sender::ProcessMessage " << *message; VLOG(1) << "Sending " << *message;
if (message->ByteSize() > static_cast<int>(kMaxPacketPayloadSizeBytes)) { if (message->ByteSize() > static_cast<int>(kMaxPacketPayloadSizeBytes)) {
DLOG(ERROR) << "Message rejected (too large): " << *message; DLOG(ERROR) << "Message rejected (too large): " << *message;
......
...@@ -56,7 +56,7 @@ void BlimpMessagePump::OnReadPacketComplete(int result) { ...@@ -56,7 +56,7 @@ void BlimpMessagePump::OnReadPacketComplete(int result) {
if (result >= 0) { if (result >= 0) {
scoped_ptr<BlimpMessage> message(new BlimpMessage); scoped_ptr<BlimpMessage> message(new BlimpMessage);
if (message->ParseFromArray(buffer_->data(), result)) { if (message->ParseFromArray(buffer_->data(), result)) {
DVLOG(2) << "OnReadPacketComplete, result=" << *message; VLOG(1) << "Received " << *message;
processor_->ProcessMessage( processor_->ProcessMessage(
std::move(message), std::move(message),
base::Bind(&BlimpMessagePump::OnProcessMessageComplete, base::Bind(&BlimpMessagePump::OnProcessMessageComplete,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment