Commit 5b5e379f authored by ap@apple.com's avatar ap@apple.com

2011-04-05 Alexey Proskuryakov <ap@apple.com>

        Reviewed by Darin Adler.

        Rename event dispatching functions after form event removal
        https://bugs.webkit.org/show_bug.cgi?id=57908

        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer):
        * dom/Node.cpp:
        (WebCore::Node::dispatchChangeEvent):
        (WebCore::Node::dispatchInputEvent):
        (WebCore::Node::defaultEventHandler):
        * dom/Node.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
        (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
        (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
        Renamed "events" to "event", since there is only one event to dispatch now.

git-svn-id: svn://svn.chromium.org/blink/trunk@83016 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 1ef1e32d
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Rename event dispatching functions after form event removal
https://bugs.webkit.org/show_bug.cgi?id=57908
* dom/InputElement.cpp:
(WebCore::InputElement::setValueFromRenderer):
* dom/Node.cpp:
(WebCore::Node::dispatchChangeEvent):
(WebCore::Node::dispatchInputEvent):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
Renamed "events" to "event", since there is only one event to dispatch now.
2011-04-05 Anders Bakken <agbakken@gmail.com> 2011-04-05 Anders Bakken <agbakken@gmail.com>
Reviewed by David Levin. Reviewed by David Levin.
...@@ -131,7 +131,7 @@ void InputElement::setValueFromRenderer(InputElementData& data, InputElement* in ...@@ -131,7 +131,7 @@ void InputElement::setValueFromRenderer(InputElementData& data, InputElement* in
// Input event is fired by the Node::defaultEventHandler for editable controls. // Input event is fired by the Node::defaultEventHandler for editable controls.
if (!inputElement->isTextField()) if (!inputElement->isTextField())
element->dispatchInputEvents(); element->dispatchInputEvent();
notifyFormStateChanged(element); notifyFormStateChanged(element);
} }
......
...@@ -2674,12 +2674,12 @@ void Node::dispatchBlurEvent() ...@@ -2674,12 +2674,12 @@ void Node::dispatchBlurEvent()
dispatchEvent(Event::create(eventNames().blurEvent, false, false)); dispatchEvent(Event::create(eventNames().blurEvent, false, false));
} }
void Node::dispatchChangeEvents() void Node::dispatchChangeEvent()
{ {
dispatchEvent(Event::create(eventNames().changeEvent, true, false)); dispatchEvent(Event::create(eventNames().changeEvent, true, false));
} }
void Node::dispatchInputEvents() void Node::dispatchInputEvent()
{ {
dispatchEvent(Event::create(eventNames().inputEvent, true, false)); dispatchEvent(Event::create(eventNames().inputEvent, true, false));
} }
...@@ -2741,7 +2741,7 @@ void Node::defaultEventHandler(Event* event) ...@@ -2741,7 +2741,7 @@ void Node::defaultEventHandler(Event* event)
if (Frame* frame = document()->frame()) if (Frame* frame = document()->frame())
frame->eventHandler()->defaultWheelEventHandler(startNode, wheelEvent); frame->eventHandler()->defaultWheelEventHandler(startNode, wheelEvent);
} else if (event->type() == eventNames().webkitEditableContentChangedEvent) { } else if (event->type() == eventNames().webkitEditableContentChangedEvent) {
dispatchInputEvents(); dispatchInputEvent();
} }
} }
......
...@@ -539,8 +539,8 @@ public: ...@@ -539,8 +539,8 @@ public:
virtual void dispatchFocusEvent(); virtual void dispatchFocusEvent();
virtual void dispatchBlurEvent(); virtual void dispatchBlurEvent();
virtual void dispatchChangeEvents(); virtual void dispatchChangeEvent();
virtual void dispatchInputEvents(); virtual void dispatchInputEvent();
// Perform the default action for an event. // Perform the default action for an event.
virtual void defaultEventHandler(Event*); virtual void defaultEventHandler(Event*);
......
...@@ -201,14 +201,14 @@ void HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent(bool chan ...@@ -201,14 +201,14 @@ void HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent(bool chan
void HTMLFormControlElement::dispatchFormControlChangeEvent() void HTMLFormControlElement::dispatchFormControlChangeEvent()
{ {
HTMLElement::dispatchChangeEvents(); HTMLElement::dispatchChangeEvent();
setChangedSinceLastFormControlChangeEvent(false); setChangedSinceLastFormControlChangeEvent(false);
} }
void HTMLFormControlElement::dispatchFormControlInputEvent() void HTMLFormControlElement::dispatchFormControlInputEvent()
{ {
setChangedSinceLastFormControlChangeEvent(true); setChangedSinceLastFormControlChangeEvent(true);
HTMLElement::dispatchInputEvents(); HTMLElement::dispatchInputEvent();
} }
void HTMLFormControlElement::setDisabled(bool b) void HTMLFormControlElement::setDisabled(bool b)
...@@ -638,7 +638,7 @@ void HTMLTextFormControlElement::select() ...@@ -638,7 +638,7 @@ void HTMLTextFormControlElement::select()
void HTMLTextFormControlElement::dispatchFormControlChangeEvent() void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
{ {
if (m_textAsOfLastFormControlChangeEvent != value()) { if (m_textAsOfLastFormControlChangeEvent != value()) {
HTMLElement::dispatchChangeEvents(); HTMLElement::dispatchChangeEvent();
setTextAsOfLastFormControlChangeEvent(value()); setTextAsOfLastFormControlChangeEvent(value());
} }
setChangedSinceLastFormControlChangeEvent(false); setChangedSinceLastFormControlChangeEvent(false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment