Commit 5b5ea84e authored by Kunihiko Sakamoto's avatar Kunihiko Sakamoto Committed by Commit Bot

Disable RefreshThrottlerTest.{QuotaIsPerDay,RollOver}

These failed on build bots probably due to the end of DST.

TBR=skym@chromium.org,fgorski@chromium.org,pnoland@chromium.org

Bug: 901698
Change-Id: I2b8231a71f483f38b161f012f7c081e35232c9a6
Reviewed-on: https://chromium-review.googlesource.com/c/1317109Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605230}
parent 70454663
...@@ -49,7 +49,8 @@ TEST_F(RefreshThrottlerTest, QuotaExceeded) { ...@@ -49,7 +49,8 @@ TEST_F(RefreshThrottlerTest, QuotaExceeded) {
EXPECT_FALSE(throttler_->RequestQuota()); EXPECT_FALSE(throttler_->RequestQuota());
} }
TEST_F(RefreshThrottlerTest, QuotaIsPerDay) { // Disabled since this is not robust against DST https://crbug.com/901698
TEST_F(RefreshThrottlerTest, DISABLED_QuotaIsPerDay) {
EXPECT_TRUE(throttler_->RequestQuota()); EXPECT_TRUE(throttler_->RequestQuota());
EXPECT_TRUE(throttler_->RequestQuota()); EXPECT_TRUE(throttler_->RequestQuota());
EXPECT_FALSE(throttler_->RequestQuota()); EXPECT_FALSE(throttler_->RequestQuota());
...@@ -58,7 +59,8 @@ TEST_F(RefreshThrottlerTest, QuotaIsPerDay) { ...@@ -58,7 +59,8 @@ TEST_F(RefreshThrottlerTest, QuotaIsPerDay) {
EXPECT_TRUE(throttler_->RequestQuota()); EXPECT_TRUE(throttler_->RequestQuota());
} }
TEST_F(RefreshThrottlerTest, RollOver) { // Disabled since this is not robust against DST https://crbug.com/901698
TEST_F(RefreshThrottlerTest, DISABLED_RollOver) {
// Exhaust our quota so the for loop can verify everything as false. // Exhaust our quota so the for loop can verify everything as false.
EXPECT_TRUE(throttler_->RequestQuota()); EXPECT_TRUE(throttler_->RequestQuota());
EXPECT_TRUE(throttler_->RequestQuota()); EXPECT_TRUE(throttler_->RequestQuota());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment