Remove error messages from credential provider logs that are not actual errors.

Bug: 938974
Change-Id: I9fa64579b8dcaf5e0434383c6068ff83a607ef65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506393
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638604}

chrome/credential_provider/gaiacp/gcp_crash_reporting_utils.cc

@@ -65,8 +65,10 @@ void InitializeGcpwCrashReporting(GcpCrashReporterClient* crash_client) {
   if (crash_dir.empty() ||
       (!base::PathExists(crash_dir) && !base::CreateDirectory(crash_dir))) {
     HRESULT hr = HRESULT_FROM_WIN32(::GetLastError());
-    LOGFN(ERROR) << "Failed to create directory for crash dumps: " << crash_dir
-                 << " hr=" << putHR(hr);
+    if (hr != HRESULT_FROM_WIN32(ERROR_ALREADY_EXISTS)) {
+      LOGFN(ERROR) << "Failed to create directory for crash dumps: "
+                   << crash_dir << " hr=" << putHR(hr);
+    }
   }
 }
 

chrome/credential_provider/gaiacp/os_user_manager.cc

@@ -480,10 +480,6 @@ HRESULT OSUserManager::FindUserBySID(const wchar_t* sid,
     wcscpy_s(domain, domain_size, local_domain_buffer);
   }
 
-  if (hr != S_OK && hr != HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER))
-    LOGFN(ERROR) << "LookupAccountSid hr=" << putHR(hr);
-
-  LOGFN(INFO) << "username=" << username << " ntdomain=" << domain;
   ::LocalFree(psid);
   return hr;
 }

chrome/credential_provider/gaiacp/scoped_lsa_policy.cc

@@ -98,11 +98,8 @@ HRESULT ScopedLsaPolicy::RetrievePrivateData(const wchar_t* key,
   LSA_UNICODE_STRING* lsa_value;
 
   NTSTATUS sts = ::LsaRetrievePrivateData(handle_, &lsa_key, &lsa_value);
-  if (sts != STATUS_SUCCESS) {
-    HRESULT hr = HRESULT_FROM_NT(sts);
-    LOGFN(ERROR) << "LsaRetrievePrivateData hr=" << putHR(hr);
-    return hr;
-  }
+  if (sts != STATUS_SUCCESS)
+    return HRESULT_FROM_NT(sts);
 
   errno_t err = wcscpy_s(value, length, lsa_value->Buffer);
   ::LsaFreeMemory(lsa_value);