Commit 5b8c5f68 authored by Luciano Pacheco's avatar Luciano Pacheco Committed by Commit Bot

Add explicit argument names to improve readability

Add named arguments to "bool" arguments with default values
for readability, as identified by the following command:

$ git ls-files | grep -E '*\.(h)$' | xargs egrep --color \
  "bool = (false|true)"

Also update the unnamed double argument in the transform
include file, IdentityTransformOperation.h

Bug: 781101
Change-Id: I7cd541b1329063805c60b3ee86247d494f8793b4
Reviewed-on: https://chromium-review.googlesource.com/759272Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Reviewed-by: default avatarChris Watkins <watk@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515457}
parent adfd4308
...@@ -106,7 +106,7 @@ class CORE_EXPORT ImageData final : public ScriptWrappable, ...@@ -106,7 +106,7 @@ class CORE_EXPORT ImageData final : public ScriptWrappable,
DOMArrayBufferView*, DOMArrayBufferView*,
const ImageDataColorSettings* = nullptr); const ImageDataColorSettings* = nullptr);
ImageData* CropRect(const IntRect&, bool = false); ImageData* CropRect(const IntRect&, bool flip_y = false);
ImageDataStorageFormat GetImageDataStorageFormat(); ImageDataStorageFormat GetImageDataStorageFormat();
static CanvasColorSpace GetCanvasColorSpace(const String&); static CanvasColorSpace GetCanvasColorSpace(const String&);
......
...@@ -427,7 +427,8 @@ class CORE_EXPORT LayoutBlock : public LayoutBox { ...@@ -427,7 +427,8 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
virtual void SimplifiedNormalFlowLayout(); virtual void SimplifiedNormalFlowLayout();
public: public:
virtual void ComputeOverflow(LayoutUnit old_client_after_edge, bool = false); virtual void ComputeOverflow(LayoutUnit old_client_after_edge,
bool recompute_floats = false);
protected: protected:
virtual void AddOverflowFromChildren(); virtual void AddOverflowFromChildren();
......
...@@ -46,9 +46,10 @@ class SVGInlineTextBox final : public InlineTextBox { ...@@ -46,9 +46,10 @@ class SVGInlineTextBox final : public InlineTextBox {
const LayoutPoint&, const LayoutPoint&,
LayoutUnit line_top, LayoutUnit line_top,
LayoutUnit line_bottom) const override; LayoutUnit line_bottom) const override;
LayoutRect LocalSelectionRect(int start_position, LayoutRect LocalSelectionRect(
int end_position, int start_position,
bool = true) const override; int end_position,
bool consider_current_selection = true) const override;
bool MapStartEndPositionsIntoFragmentCoordinates(const SVGTextFragment&, bool MapStartEndPositionsIntoFragmentCoordinates(const SVGTextFragment&,
int& start_position, int& start_position,
......
...@@ -228,9 +228,10 @@ class PLATFORM_EXPORT FontCache { ...@@ -228,9 +228,10 @@ class PLATFORM_EXPORT FontCache {
const char* preferred_locale, const char* preferred_locale,
PlatformFallbackFont*); PlatformFallbackFont*);
#endif #endif
scoped_refptr<SimpleFontData> FontDataFromFontPlatformData(const FontPlatformData*, scoped_refptr<SimpleFontData> FontDataFromFontPlatformData(
ShouldRetain = kRetain, const FontPlatformData*,
bool = false); ShouldRetain = kRetain,
bool subpixel_ascent_descent = false);
void InvalidateShapeCache(); void InvalidateShapeCache();
......
...@@ -75,8 +75,8 @@ class FontDataCache { ...@@ -75,8 +75,8 @@ class FontDataCache {
FontDataCache() {} FontDataCache() {}
scoped_refptr<SimpleFontData> Get(const FontPlatformData*, scoped_refptr<SimpleFontData> Get(const FontPlatformData*,
ShouldRetain = kRetain, ShouldRetain = kRetain,
bool = false); bool subpixel_ascent_descent = false);
bool Contains(const FontPlatformData*) const; bool Contains(const FontPlatformData*) const;
void Release(const SimpleFontData*); void Release(const SimpleFontData*);
......
...@@ -49,9 +49,10 @@ class PLATFORM_EXPORT IdentityTransformOperation final ...@@ -49,9 +49,10 @@ class PLATFORM_EXPORT IdentityTransformOperation final
void Apply(TransformationMatrix&, const FloatSize&) const override {} void Apply(TransformationMatrix&, const FloatSize&) const override {}
scoped_refptr<TransformOperation> Blend(const TransformOperation*, scoped_refptr<TransformOperation> Blend(
double, const TransformOperation*,
bool = false) override { double progress,
bool blend_to_identity = false) override {
return this; return this;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment