Commit 5bb8ae3e authored by kjoswiak's avatar kjoswiak Committed by Commit bot

Clean up redundant virtual specifiers for chromecast android

BUG=None

Review URL: https://codereview.chromium.org/917303002

Cr-Commit-Position: refs/heads/master@{#316660}
parent 07d958d9
......@@ -44,7 +44,7 @@ class CastWindowAndroid : public content::WebContentsDelegate,
content::BrowserContext* browser_context,
const GURL& url);
virtual ~CastWindowAndroid();
~CastWindowAndroid() override;
void LoadURL(const GURL& url);
// Calls RVH::ClosePage() and waits for acknowledgement before closing/
......@@ -57,24 +57,24 @@ class CastWindowAndroid : public content::WebContentsDelegate,
static bool RegisterJni(JNIEnv* env);
// content::WebContentsDelegate implementation:
virtual void AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_rect,
bool user_gesture,
bool* was_blocked) override;
virtual void CloseContents(content::WebContents* source) override;
virtual bool CanOverscrollContent() const override;
virtual bool AddMessageToConsole(content::WebContents* source,
int32 level,
const base::string16& message,
int32 line_no,
const base::string16& source_id) override;
virtual void ActivateContents(content::WebContents* contents) override;
virtual void DeactivateContents(content::WebContents* contents) override;
void AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_rect,
bool user_gesture,
bool* was_blocked) override;
void CloseContents(content::WebContents* source) override;
bool CanOverscrollContent() const override;
bool AddMessageToConsole(content::WebContents* source,
int32 level,
const base::string16& message,
int32 line_no,
const base::string16& source_id) override;
void ActivateContents(content::WebContents* contents) override;
void DeactivateContents(content::WebContents* contents) override;
// content::WebContentsObserver implementation:
virtual void RenderProcessGone(base::TerminationStatus status) override;
void RenderProcessGone(base::TerminationStatus status) override;
private:
explicit CastWindowAndroid(content::BrowserContext* browser_context);
......
......@@ -24,14 +24,14 @@ class ExternalVideoSurfaceContainerImpl
ExternalVideoSurfaceContainerImpl(content::WebContents* contents);
// ExternalVideoSurfaceContainer implementation.
virtual void RequestExternalVideoSurface(
void RequestExternalVideoSurface(
int player_id,
const SurfaceCreatedCB& surface_created_cb,
const SurfaceDestroyedCB& surface_destroyed_cb) override;
virtual int GetCurrentPlayerId() override;
virtual void ReleaseExternalVideoSurface(int player_id) override;
virtual void OnFrameInfoUpdated() override;
virtual void OnExternalVideoSurfacePositionChanged(
int GetCurrentPlayerId() override;
void ReleaseExternalVideoSurface(int player_id) override;
void OnFrameInfoUpdated() override;
void OnExternalVideoSurfacePositionChanged(
int player_id, const gfx::RectF& rect) override;
// Methods called from Java.
......@@ -40,7 +40,7 @@ class ExternalVideoSurfaceContainerImpl
void SurfaceDestroyed(JNIEnv* env, jobject obj, jint player_id);
private:
virtual ~ExternalVideoSurfaceContainerImpl();
~ExternalVideoSurfaceContainerImpl() override;
base::android::ScopedJavaGlobalRef<jobject> jobject_;
......
......@@ -14,16 +14,16 @@ class CastCrashReporterClientAndroid
: public crash_reporter::CrashReporterClient {
public:
CastCrashReporterClientAndroid();
virtual ~CastCrashReporterClientAndroid();
~CastCrashReporterClientAndroid() override;
// crash_reporter::CrashReporterClient implementation:
virtual void GetProductNameAndVersion(const char** product_name,
const char** version) override;
virtual base::FilePath GetReporterLogFilename() override;
virtual bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
virtual int GetAndroidMinidumpDescriptor() override;
virtual bool GetCollectStatsConsent() override;
virtual bool EnableBreakpadForProcess(
void GetProductNameAndVersion(const char** product_name,
const char** version) override;
base::FilePath GetReporterLogFilename() override;
bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
int GetAndroidMinidumpDescriptor() override;
bool GetCollectStatsConsent() override;
bool EnableBreakpadForProcess(
const std::string& process_type) override;
private:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment