Enable Minikin hyphenation engine on all platforms but Mac
This patch enables the Minikin hyphenation engine on all platforms except Mac. Mac keeps using the engine in the OS. Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/sIRXYKA4jGE/m/44YfDTNkAwAJ Test expectation changes are: * Linux/Win support `hyphens: auto` as a valid CSS. * Unskip tests that require `hyphens: auto` on Linux/Win. * Some Mac-only failures now fail on all platforms. * Triaged 1 new failure on Linux and 2 on Windows. The causes are existing ones, but results vary by platform as tests rely on fonts and dictionaries. I'll review existing issues. Note, |web_tests| and |content_shell| use the dictionaries in the repository (r818216 crrev.com/c/2478122), while in Chromium, the [component updater] downloads the dictionaries (r816137 crrev.com/c/2437314) and passes to the engine when they become ready (r817902 crrev.com/c/2462893). [component updater]: https://chromium.googlesource.com/chromium/src/+/master/components/component_updater/README.md Bug: 652964 Change-Id: I82e3df40ea59256aa61de24bce4be39870e85adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315564Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818370}
Showing
Please register or sign in to comment