Commit 5bc2dfed authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

Enable Minikin hyphenation engine on all platforms but Mac

This patch enables the Minikin hyphenation engine on all
platforms except Mac. Mac keeps using the engine in the OS.

Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/sIRXYKA4jGE/m/44YfDTNkAwAJ

Test expectation changes are:
* Linux/Win support `hyphens: auto` as a valid CSS.
* Unskip tests that require `hyphens: auto` on Linux/Win.
* Some Mac-only failures now fail on all platforms.
* Triaged 1 new failure on Linux and 2 on Windows. The causes
  are existing ones, but results vary by platform as tests
  rely on fonts and dictionaries. I'll review existing issues.

Note, |web_tests| and |content_shell| use the dictionaries in
the repository (r818216 crrev.com/c/2478122), while in
Chromium, the [component updater] downloads the dictionaries
(r816137 crrev.com/c/2437314) and passes to the engine when
they become ready (r817902 crrev.com/c/2462893).

[component updater]: https://chromium.googlesource.com/chromium/src/+/master/components/component_updater/README.md

Bug: 652964
Change-Id: I82e3df40ea59256aa61de24bce4be39870e85adb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315564Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818370}
parent 7b16dac8
......@@ -27,4 +27,4 @@ declare_args() {
enable_unhandled_tap = is_android
# Use Minikin hyphenation engine.
use_minikin_hyphenation = is_android
use_minikin_hyphenation = !is_mac
......@@ -1558,30 +1558,6 @@ crbug.com/552494 virtual/prefer_compositing_to_lcd_text/scrollbars/overflow-scro
crbug.com/1056027 [ Fuchsia ] virtual/text-antialias/small-caps-aat.html [ Skip ]
crbug.com/1057339 [ Fuchsia ] virtual/text-antialias/international/rtl-mark.html [ Skip ]
# `hyphens: auto` not supported on Win/Linux/ChromeOS
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphen-min-preferred-width-mock.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphen-min-preferred-width-mock.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphens-align.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphens-align.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphens-auto.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphens-auto.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphens-auto-mock.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphens-auto-mock.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphens-auto-nowrap.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphens-auto-nowrap.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphens-locale.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphens-locale.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/hyphens-orphaned-word.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/hyphens-orphaned-word.html [ Skip ]
crbug.com/652964 [ Linux ] virtual/text-antialias/hyphens/midword-break-priority.html [ Skip ]
crbug.com/652964 [ Win ] virtual/text-antialias/hyphens/midword-break-priority.html [ Skip ]
crbug.com/652964 [ Linux ] external/wpt/css/css-text/hyphens/hyphens-auto-010.html [ Skip ]
crbug.com/652964 [ Win ] external/wpt/css/css-text/hyphens/hyphens-auto-010.html [ Skip ]
crbug.com/652964 [ Linux ] external/wpt/css/css-text/hyphens/hyphens-auto-inline-010.html [ Skip ]
crbug.com/652964 [ Win ] external/wpt/css/css-text/hyphens/hyphens-auto-inline-010.html [ Skip ]
crbug.com/652964 [ Linux ] external/wpt/css/css-text/hyphens/hyphens-none-013.html [ Skip ]
crbug.com/652964 [ Win ] external/wpt/css/css-text/hyphens/hyphens-none-013.html [ Skip ]
crbug.com/305376 external/wpt/css/css-overflow/webkit-line-clamp-018.html [ Failure ]
crbug.com/305376 external/wpt/css/css-overflow/webkit-line-clamp-024.html [ Failure ]
crbug.com/1007065 external/wpt/css/css-overflow/overflow-codependent-scrollbars.html [ Failure ]
......@@ -1655,16 +1631,19 @@ crbug.com/1022182 virtual/module-top-level-await/external/wpt/html/webappapis/dy
crbug.com/1022182 virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-promise.html [ Pass ]
crbug.com/676270 [ Mac ] external/wpt/css/css-text/hyphens/hyphens-auto-001.html [ Failure ]
crbug.com/1022415 [ Mac ] external/wpt/css/css-text/hyphens/hyphens-auto-010.html [ Failure ]
crbug.com/1022415 external/wpt/css/css-text/hyphens/hyphens-auto-010.html [ Failure ]
crbug.com/1022415 [ Linux ] external/wpt/css/css-text/hyphens/hyphens-auto-inline-010.html [ Failure ]
crbug.com/1022415 [ Win ] external/wpt/css/css-text/hyphens/hyphens-auto-inline-010.html [ Failure ]
crbug.com/963369 external/wpt/css/css-text/hyphens/hyphens-out-of-flow-001.html [ Failure ]
crbug.com/963369 external/wpt/css/css-text/hyphens/hyphens-out-of-flow-002.html [ Failure ]
crbug.com/639223 external/wpt/css/css-text/hyphens/hyphens-shaping-002.html [ Failure ]
crbug.com/639223 external/wpt/css/css-text/hyphens/hyphens-span-001.html [ Failure ]
crbug.com/639223 [ Mac ] external/wpt/css/css-text/hyphens/hyphens-span-002.html [ Failure ]
crbug.com/639223 external/wpt/css/css-text/hyphens/shy-styling-001.html [ Failure ]
crbug.com/870219 [ Mac ] virtual/text-antialias/hyphens/hyphen-min-preferred-width-mock.html [ Failure ]
crbug.com/870219 [ Mac ] virtual/text-antialias/hyphens/hyphens-auto-mock.html [ Failure ]
crbug.com/1139693 [ Mac ] virtual/text-antialias/hyphens/midword-break-priority.html [ Failure ]
crbug.com/870219 virtual/text-antialias/hyphens/hyphen-min-preferred-width-mock.html [ Failure ]
crbug.com/870219 [ Win ] virtual/text-antialias/hyphens/hyphens-auto.html [ Failure ]
crbug.com/870219 virtual/text-antialias/hyphens/hyphens-auto-mock.html [ Failure ]
crbug.com/1139693 virtual/text-antialias/hyphens/midword-break-priority.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/letter-spacing/letter-spacing-control-chars-001.html [ Failure ]
crbug.com/921318 external/wpt/css/css-text/tab-size/tab-size-spacing-001.html [ Failure ]
......
This is a testharness.js-based test.
PASS Property hyphens value 'none'
PASS Property hyphens value 'manual'
PASS Property hyphens value 'auto'
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Property hyphens value 'none'
PASS Property hyphens value 'manual'
FAIL Property hyphens value 'auto' assert_true: 'auto' is a supported value for hyphens. expected true got false
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS e.style['hyphens'] = "none" should set the property value
PASS e.style['hyphens'] = "manual" should set the property value
FAIL e.style['hyphens'] = "auto" should set the property value assert_not_equals: property should be set got disallowed value ""
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Initial value
FAIL hyphens: auto assert_equals: expected "auto" but got "manual"
PASS hyphens: manual
PASS hyphens: none
FAIL hyphens should inherit assert_equals: expected "auto" but got "manual"
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment