Commit 5bdc25c1 authored by cfredric's avatar cfredric Committed by Chromium LUCI CQ

Fix comments per clang-tidy bugprone-argument-comment warning.

Change-Id: I949eb8b83207b689b8d516391a86a5e0cbd03b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607555
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: default avatarLily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840165}
parent c87d4517
...@@ -91,7 +91,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchSessionControl) { ...@@ -91,7 +91,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchSessionControl) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
auto session_cookie = CanonicalCookie::CreateUnsafeCookieForTesting( auto session_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
"session-cookie", "session-value", "session-domain", "session-path", "session-cookie", "session-value", "session-domain", "session-path",
...@@ -101,7 +101,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchSessionControl) { ...@@ -101,7 +101,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchSessionControl) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
CookieDeletionInfo delete_info; CookieDeletionInfo delete_info;
EXPECT_TRUE(delete_info.Matches( EXPECT_TRUE(delete_info.Matches(
...@@ -146,7 +146,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchHost) { ...@@ -146,7 +146,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchHost) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
auto host_cookie = CanonicalCookie::CreateUnsafeCookieForTesting( auto host_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
"host-cookie", "host-cookie-value", "host-cookie", "host-cookie-value",
...@@ -157,7 +157,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchHost) { ...@@ -157,7 +157,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchHost) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
EXPECT_TRUE(domain_cookie->IsDomainCookie()); EXPECT_TRUE(domain_cookie->IsDomainCookie());
EXPECT_TRUE(host_cookie->IsHostCookie()); EXPECT_TRUE(host_cookie->IsHostCookie());
...@@ -213,7 +213,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchName) { ...@@ -213,7 +213,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchName) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
auto cookie2 = CanonicalCookie::CreateUnsafeCookieForTesting( auto cookie2 = CanonicalCookie::CreateUnsafeCookieForTesting(
"cookie2-name", "cookie2-value", "cookie2-name", "cookie2-value",
/*domain=*/".example.com", "/path", /*domain=*/".example.com", "/path",
...@@ -223,7 +223,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchName) { ...@@ -223,7 +223,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchName) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
CookieDeletionInfo delete_info; CookieDeletionInfo delete_info;
delete_info.name = "cookie1-name"; delete_info.name = "cookie1-name";
...@@ -247,7 +247,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchValue) { ...@@ -247,7 +247,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchValue) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
auto cookie2 = CanonicalCookie::CreateUnsafeCookieForTesting( auto cookie2 = CanonicalCookie::CreateUnsafeCookieForTesting(
"cookie2-name", "cookie2-value", "cookie2-name", "cookie2-value",
/*domain=*/".example.com", "/path", /*domain=*/".example.com", "/path",
...@@ -257,7 +257,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchValue) { ...@@ -257,7 +257,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchValue) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
CookieDeletionInfo delete_info; CookieDeletionInfo delete_info;
delete_info.value_for_testing = "cookie2-value"; delete_info.value_for_testing = "cookie2-value";
...@@ -281,7 +281,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchUrl) { ...@@ -281,7 +281,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchUrl) {
/*secure=*/true, /*secure=*/true,
/*httponly=*/false, CookieSameSite::NO_RESTRICTION, /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
CookiePriority::COOKIE_PRIORITY_DEFAULT, CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
CookieDeletionInfo delete_info; CookieDeletionInfo delete_info;
delete_info.url = GURL("https://www.example.com/path"); delete_info.url = GURL("https://www.example.com/path");
...@@ -331,7 +331,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoDomainMatchesDomain) { ...@@ -331,7 +331,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoDomainMatchesDomain) {
/*httponly=*/false, /*httponly=*/false,
/*same_site=*/CookieSameSite::NO_RESTRICTION, /*same_site=*/CookieSameSite::NO_RESTRICTION,
/*priority=*/CookiePriority::COOKIE_PRIORITY_DEFAULT, /*priority=*/CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
}; };
// by default empty domain list and default match action will match. // by default empty domain list and default match action will match.
...@@ -391,7 +391,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchesDomainList) { ...@@ -391,7 +391,7 @@ TEST(CookieDeletionInfoTest, CookieDeletionInfoMatchesDomainList) {
/*httponly=*/false, /*httponly=*/false,
/*same_site=*/CookieSameSite::NO_RESTRICTION, /*same_site=*/CookieSameSite::NO_RESTRICTION,
/*priority=*/CookiePriority::COOKIE_PRIORITY_DEFAULT, /*priority=*/CookiePriority::COOKIE_PRIORITY_DEFAULT,
/*sameparty=*/false); /*same_party=*/false);
}; };
// With two empty lists (default) should match any domain. // With two empty lists (default) should match any domain.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment