CrOS FileManager UMA ClickBreadCrumbs

Added ClickBreadcrumbs user action for click in breadcrumb.

Fixed handling of MockFileSystem root to always include trailing slash.
The root dir is referenced in the breadcrumb and causes errors
in tests  with inconsistency of trailing slash.



Bug: 824607
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ff72f4d2542c25f87fd495bdb088d0d3315424f
Reviewed-on: https://chromium-review.googlesource.com/977381
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545740}

tools/metrics/actions/actions.xml

@@ -5003,6 +5003,13 @@ should be able to be added at any place in this file.
   </description>
 </action>
 
+<action name="FileBrowser.ClickBreadcrumbs">
+  <owner>joelhockey@chromium.org</owner>
+  <description>
+    User clicked the breadcrumbs in order to return to a parent directory.
+  </description>
+</action>
+
 <action name="FileBrowser.CreateNewFolder">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>

ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

@@ -268,6 +268,7 @@
       'dependencies': [
         '../../../../externs/compiled_resources2.gyp:platform',
         '../../../../externs/compiled_resources2.gyp:volume_manager',
+        '../../../common/js/compiled_resources2.gyp:metrics',
         '../../../common/js/compiled_resources2.gyp:util',
         '../../../common/js/compiled_resources2.gyp:volume_manager_common',
         '../compiled_resources2.gyp:volume_manager_wrapper',

ui/file_manager/file_manager/foreground/js/ui/location_line.js

@@ -336,6 +336,7 @@ LocationLine.prototype.onClick_ = function(index, event) {
     pathClickEvent.entry = entry;
     this.dispatchEvent(pathClickEvent);
   }.bind(this));
+  metrics.recordUserAction('ClickBreadcrumbs');
 };
 
 /**

ui/file_manager/file_manager/test/js/chrome_api_test_impl.js

@@ -69,6 +69,7 @@ chrome = {
   },
 
   metricsPrivate: {
+    userActions_: [],
     MetricTypeType: {
       HISTOGRAM_LINEAR: 'histogram-linear',
     },
@@ -76,7 +77,9 @@ chrome = {
     recordPercentage: () => {},
     recordSmallCount: () => {},
     recordTime: () => {},
-    recordUserAction: () => {},
+    recordUserAction: (action) => {
+      chrome.metricsPrivate.userActions_.push(action);
+    },
     recordValue: () => {},
   },
 

ui/file_manager/file_manager/test/uma.js

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function testClickBreadcrumb(done) {
+  test.setupAndWaitUntilReady()
+      .then(() => {
+        // Reset metrics.
+        chrome.metricsPrivate.userActions_ = [];
+        // Click first row which is 'photos' dir, wait for breadcrumb to show.
+        assertTrue(test.fakeMouseDoubleClick('#file-list li.table-row'));
+        return test.waitForElement(
+            '#location-breadcrumbs .breadcrumb-path:nth-of-type(2)');
+      })
+      .then(result => {
+        // Click breadcrumb to return to parent dir.
+        assertTrue(test.fakeMouseClick(
+            '#location-breadcrumbs .breadcrumb-path:nth-of-type(1)'));
+        return test.waitForFiles(
+            test.TestEntryInfo.getExpectedRows(test.BASIC_LOCAL_ENTRY_SET));
+      })
+      .then(result => {
+        assertArrayEquals(
+            ['FileBrowser.ClickBreadcrumbs'],
+            chrome.metricsPrivate.userActions_);
+        done();
+      });
+}