Commit 5bf9fffb authored by Nico Weber's avatar Nico Weber

Work more on getting things built with -Wimplicit-fallthrough.

This CL was uploaded by git cl split.

R=kinuko@chromium.org

Bug: 177475
Change-Id: Idd08baf5677ac2e2c6da37c1a73c9c2dd957ecc9
Reviewed-on: https://chromium-review.googlesource.com/889942Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532352}
parent 5545b337
...@@ -186,7 +186,7 @@ AtomicString LayoutLocale::LocaleWithBreakKeyword( ...@@ -186,7 +186,7 @@ AtomicString LayoutLocale::LocaleWithBreakKeyword(
switch (mode) { switch (mode) {
default: default:
NOTREACHED(); NOTREACHED();
// Fall through. FALLTHROUGH;
case LineBreakIteratorMode::kDefault: case LineBreakIteratorMode::kDefault:
// nullptr will cause any existing values to be removed. // nullptr will cause any existing values to be removed.
break; break;
......
...@@ -949,6 +949,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -949,6 +949,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
} }
AppendRun(runs_); AppendRun(runs_);
} }
break;
default: default:
break; break;
} }
...@@ -964,6 +965,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -964,6 +965,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
case WTF::Unicode::kEuropeanNumber: case WTF::Unicode::kEuropeanNumber:
case WTF::Unicode::kArabicNumber: case WTF::Unicode::kArabicNumber:
AppendRun(runs_); AppendRun(runs_);
break;
case WTF::Unicode::kRightToLeft: case WTF::Unicode::kRightToLeft:
case WTF::Unicode::kRightToLeftArabic: case WTF::Unicode::kRightToLeftArabic:
break; break;
...@@ -987,6 +989,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -987,6 +989,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
eor_ = last_; eor_ = last_;
AppendRun(runs_); AppendRun(runs_);
} }
break;
default: default:
break; break;
} }
...@@ -1016,6 +1019,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -1016,6 +1019,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
case WTF::Unicode::kCommonNumberSeparator: case WTF::Unicode::kCommonNumberSeparator:
if (status_.eor == WTF::Unicode::kEuropeanNumber) if (status_.eor == WTF::Unicode::kEuropeanNumber)
break; break;
FALLTHROUGH;
case WTF::Unicode::kEuropeanNumberTerminator: case WTF::Unicode::kEuropeanNumberTerminator:
case WTF::Unicode::kBoundaryNeutral: case WTF::Unicode::kBoundaryNeutral:
case WTF::Unicode::kBlockSeparator: case WTF::Unicode::kBlockSeparator:
...@@ -1060,6 +1064,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -1060,6 +1064,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
// Begin a new EN run. // Begin a new EN run.
direction_ = WTF::Unicode::kEuropeanNumber; direction_ = WTF::Unicode::kEuropeanNumber;
} }
break;
default: default:
break; break;
} }
...@@ -1087,6 +1092,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -1087,6 +1092,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
case WTF::Unicode::kCommonNumberSeparator: case WTF::Unicode::kCommonNumberSeparator:
if (status_.eor == WTF::Unicode::kArabicNumber) if (status_.eor == WTF::Unicode::kArabicNumber)
break; break;
FALLTHROUGH;
case WTF::Unicode::kEuropeanNumberSeparator: case WTF::Unicode::kEuropeanNumberSeparator:
case WTF::Unicode::kEuropeanNumberTerminator: case WTF::Unicode::kEuropeanNumberTerminator:
case WTF::Unicode::kBoundaryNeutral: case WTF::Unicode::kBoundaryNeutral:
...@@ -1112,6 +1118,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine( ...@@ -1112,6 +1118,7 @@ void BidiResolver<Iterator, Run, IsolatedRun>::CreateBidiRunsForLine(
} }
eor_ = last_; eor_ = last_;
AppendRun(runs_); AppendRun(runs_);
break;
default: default:
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment