Commit 5c06d64a authored by Elad Alon's avatar Elad Alon Committed by Commit Bot

Fix order of methods in WebRtcEventLogManager

This is a purely cosmetic change, bring the order of the private
methods in line with the public ones. (The order of the public methods
was changed by a previous CL that made some of the methods virtual.)

Bug: 775415
Change-Id: I978cc34bc1ac6ffa579608030de3ac1343f7eb92
Reviewed-on: https://chromium-review.googlesource.com/966905Reviewed-by: default avatarTommi <tommi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544349}
parent 680f1331
......@@ -523,6 +523,27 @@ void WebRtcEventLogManager::DisableLocalLoggingInternal(
}
}
void WebRtcEventLogManager::OnWebRtcEventLogWriteInternal(
PeerConnectionKey key,
bool remote_logging_allowed,
const std::string& message,
base::OnceCallback<void(std::pair<bool, bool>)> reply) {
DCHECK(task_runner_->RunsTasksInCurrentSequence());
const bool local_result = local_logs_manager_.EventLogWrite(key, message);
const bool remote_result =
(remote_logging_allowed && remote_logs_manager_)
? remote_logs_manager_->EventLogWrite(key, message)
: false;
if (reply) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::BindOnce(std::move(reply),
std::make_pair(local_result, remote_result)));
}
}
void WebRtcEventLogManager::StartRemoteLoggingInternal(
int render_process_id,
BrowserContextId browser_context_id,
......@@ -546,27 +567,6 @@ void WebRtcEventLogManager::StartRemoteLoggingInternal(
}
}
void WebRtcEventLogManager::OnWebRtcEventLogWriteInternal(
PeerConnectionKey key,
bool remote_logging_allowed,
const std::string& message,
base::OnceCallback<void(std::pair<bool, bool>)> reply) {
DCHECK(task_runner_->RunsTasksInCurrentSequence());
const bool local_result = local_logs_manager_.EventLogWrite(key, message);
const bool remote_result =
(remote_logging_allowed && remote_logs_manager_)
? remote_logs_manager_->EventLogWrite(key, message)
: false;
if (reply) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::BindOnce(std::move(reply),
std::make_pair(local_result, remote_result)));
}
}
void WebRtcEventLogManager::RenderProcessExitedInternal(int render_process_id) {
DCHECK(task_runner_->RunsTasksInCurrentSequence());
local_logs_manager_.RenderProcessHostExitedDestroyed(render_process_id);
......
......@@ -216,6 +216,12 @@ class WebRtcEventLogManager final : public content::RenderProcessHostObserver,
base::OnceCallback<void(bool)> reply);
void DisableLocalLoggingInternal(base::OnceCallback<void(bool)> reply);
void OnWebRtcEventLogWriteInternal(
PeerConnectionKey key,
bool remote_logging_allowed,
const std::string& message,
base::OnceCallback<void(std::pair<bool, bool>)> reply);
void StartRemoteLoggingInternal(int render_process_id,
BrowserContextId browser_context_id,
const std::string& peer_connection_id,
......@@ -224,12 +230,6 @@ class WebRtcEventLogManager final : public content::RenderProcessHostObserver,
const std::string& metadata,
base::OnceCallback<void(bool)> reply);
void OnWebRtcEventLogWriteInternal(
PeerConnectionKey key,
bool remote_logging_allowed,
const std::string& message,
base::OnceCallback<void(std::pair<bool, bool>)> reply);
void RenderProcessExitedInternal(int render_process_id);
void SetLocalLogsObserverInternal(WebRtcLocalEventLogsObserver* observer,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment