Commit 5c3231cd authored by Ahmed Mehfooz's avatar Ahmed Mehfooz Committed by Commit Bot

Fix detailed view padding

Modify mic slider view padding and overall detailed view padding
to bring up to spec provided in the bug.

Bug: 1086993
Change-Id: I2b8719811070234b9a06694053370bfb8c7eae82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464242Reviewed-by: default avatarTim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815884}
parent 5764a5ea
......@@ -107,7 +107,7 @@ constexpr gfx::Insets kUnifiedManagedDeviceViewPadding(0, 16, 11, 16);
constexpr gfx::Insets kUnifiedSliderRowPadding(0, 16, 8, 16);
constexpr gfx::Insets kUnifiedSliderBubblePadding(12, 0, 4, 0);
constexpr gfx::Insets kUnifiedSliderPadding(0, 16);
constexpr gfx::Insets kMicGainSliderViewPadding(0, 52, 0, 0);
constexpr gfx::Insets kMicGainSliderViewPadding(0, 52, 8, 0);
constexpr gfx::Insets kMicGainSliderPadding(0, 8, 0, 48);
constexpr int kMicGainSliderViewSpacing = 8;
......@@ -213,7 +213,8 @@ constexpr int kUnifiedUserChooserRowHeight = 64;
constexpr int kUnifiedTopShortcutButtonDefaultSpacing = 16;
constexpr int kUnifiedTopShortcutButtonMinSpacing = 4;
// Constants used in the title row of a detailed view in UnifiedSystemTray.
// Constants used in the detailed view in UnifiedSystemTray.
constexpr gfx::Insets kUnifiedDetailedViewPadding(0, 0, 8, 0);
constexpr gfx::Insets kUnifiedDetailedViewTitlePadding(0, 0, 0, 16);
constexpr int kUnifiedDetailedViewTitleRowHeight = 64;
......
......@@ -271,7 +271,7 @@ class ScrollContentsView : public views::View {
TrayDetailedView::TrayDetailedView(DetailedViewDelegate* delegate)
: delegate_(delegate) {
box_layout_ = SetLayoutManager(std::make_unique<views::BoxLayout>(
views::BoxLayout::Orientation::kVertical));
views::BoxLayout::Orientation::kVertical, kUnifiedDetailedViewPadding));
SetBackground(views::CreateSolidBackground(
delegate_->GetBackgroundColor().value_or(SK_ColorTRANSPARENT)));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment