Commit 5c3c61b0 authored by Adam Langley's avatar Adam Langley Committed by Commit Bot

webauthn: error immediately if user denies consent for direct attestation

https://w3c.github.io/webauthn/#sec-assertion-privacy says that we
should be careful that sites can't probe information about
authenticators.

In this case the user has touched an authenticator for a registration
but denied consent to supply direct attestation information. Currently
we let the registration timeout. But with this change we'll return an
error to the site immediately.

Change-Id: Icccbdb4f3b56824d2ea5114e7edae4db988f36f9
Reviewed-on: https://chromium-review.googlesource.com/978951Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545834}
parent ce8ac034
...@@ -590,9 +590,9 @@ void AuthenticatorImpl::OnRegisterResponseAttestationDecided( ...@@ -590,9 +590,9 @@ void AuthenticatorImpl::OnRegisterResponseAttestationDecided(
webauth::mojom::AttestationConveyancePreference::NONE); webauth::mojom::AttestationConveyancePreference::NONE);
if (!attestation_permitted) { if (!attestation_permitted) {
// To protect users from being identified without consent, we let the InvokeCallbackAndCleanup(
// timeout run out. std::move(make_credential_response_callback_),
// See https://w3c.github.io/webauthn/#sec-assertion-privacy. webauth::mojom::AuthenticatorStatus::NOT_ALLOWED_ERROR, nullptr);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment