Commit 5c420b42 authored by dpapad@chromium.org's avatar dpapad@chromium.org

Print Preview: Changing tab title and invalid page range error message

BUG=83252, 82956
TEST=See bug description.

Review URL: http://codereview.chromium.org/7065007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86377 0039d316-1c4b-4281-b951-d872f2087c98
parent 24cd3e8d
...@@ -5554,7 +5554,7 @@ Keep your key file in a safe place. You will need it to create new versions of y ...@@ -5554,7 +5554,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
Print preview Print preview
</message> </message>
<message name="IDS_PRINT_PREVIEW_TITLE_FORMAT" desc="The format for the print preview page title."> <message name="IDS_PRINT_PREVIEW_TITLE_FORMAT" desc="The format for the print preview page title.">
Print Preview - <ph name="PREVIEW_TAB_TITLE">$1<ex>Google Search</ex></ph> Print preview - <ph name="PREVIEW_TAB_TITLE">$1<ex>Google Search</ex></ph>
</message> </message>
<message name="IDS_PRINT_PREVIEW_LOADING_PRINTERS" desc="Message to display while the print preview is still loading the printer list."> <message name="IDS_PRINT_PREVIEW_LOADING_PRINTERS" desc="Message to display while the print preview is still loading the printer list.">
Loading additional printers Loading additional printers
...@@ -5619,10 +5619,6 @@ Keep your key file in a safe place. You will need it to create new versions of y ...@@ -5619,10 +5619,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_PRINT_PREVIEW_PAGE_RANGE_RADIO" desc="Aria-label page range radio."> <message name="IDS_PRINT_PREVIEW_PAGE_RANGE_RADIO" desc="Aria-label page range radio.">
page range radio button page range radio button
</message> </message>
<message name="IDS_PRINT_PREVIEW_INVALID_PAGE_RANGE"
desc="Warning message shown when the text entered by the user does not represent a valid page range.">
Invalid page range
</message>
<message name="IDS_PRINT_PREVIEW_INVALID_NUMBER_OF_COPIES" <message name="IDS_PRINT_PREVIEW_INVALID_NUMBER_OF_COPIES"
desc="Warning message shown when the text entered by the user does not represent a valid number of copies."> desc="Warning message shown when the text entered by the user does not represent a valid number of copies.">
Invalid number of copies Invalid number of copies
...@@ -5685,7 +5681,7 @@ Keep your key file in a safe place. You will need it to create new versions of y ...@@ -5685,7 +5681,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
Advanced… Advanced…
</message> </message>
<message name="IDS_PRINT_PREVIEW_PAGE_RANGE_INSTRUCTION" desc="Instruction shown when the user enters an invalid page range."> <message name="IDS_PRINT_PREVIEW_PAGE_RANGE_INSTRUCTION" desc="Instruction shown when the user enters an invalid page range.">
Use page ranges, <ph name="EXAMPLE_PAGE_RANGE">$1<ex>e.g. 1-5, 8, 11-13</ex></ph> Invalid page range, use <ph name="EXAMPLE_PAGE_RANGE">$1<ex>e.g. 1-5, 8, 11-13</ex></ph>
</message> </message>
<message name="IDS_PRINT_PREVIEW_COPIES_INSTRUCTION" desc="Instruction shown when the user enters an invalid number of copies."> <message name="IDS_PRINT_PREVIEW_COPIES_INSTRUCTION" desc="Instruction shown when the user enters an invalid number of copies.">
Use a number to indicate how many copies to print (1 or more). Use a number to indicate how many copies to print (1 or more).
......
...@@ -616,7 +616,7 @@ function updatePrintSummary() { ...@@ -616,7 +616,7 @@ function updatePrintSummary() {
} }
if (getSelectedPagesValidityLevel() != 1) { if (getSelectedPagesValidityLevel() != 1) {
printSummary.innerHTML = localStrings.getString('invalidPageRange'); printSummary.innerHTML = '';
return; return;
} }
......
...@@ -78,8 +78,6 @@ void SetLocalizedStrings(DictionaryValue* localized_strings) { ...@@ -78,8 +78,6 @@ void SetLocalizedStrings(DictionaryValue* localized_strings) {
l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_PAGE_RANGE_TEXT)); l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_PAGE_RANGE_TEXT));
localized_strings->SetString(std::string("pageRangeRadio"), localized_strings->SetString(std::string("pageRangeRadio"),
l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_PAGE_RANGE_RADIO)); l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_PAGE_RANGE_RADIO));
localized_strings->SetString(std::string("invalidPageRange"),
l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_INVALID_PAGE_RANGE));
localized_strings->SetString(std::string("printToPDF"), localized_strings->SetString(std::string("printToPDF"),
l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_PRINT_TO_PDF)); l10n_util::GetStringUTF8(IDS_PRINT_PREVIEW_PRINT_TO_PDF));
localized_strings->SetString(std::string("printPreviewTitleFormat"), localized_strings->SetString(std::string("printPreviewTitleFormat"),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment