Commit 5c75624c authored by Mark Brand's avatar Mark Brand Committed by Commit Bot

Disable fuzzing generation for //gpu/ipc/common:vulkan_interfaces.

This CL disables fuzzing generation for the vulkan mojom target
when enable_vulkan isn't set, since the generated MojoLPM fuzzer
code will expect the vulkan headers to be available.

This is a cherrypick/split from
https://chromium-review.googlesource.com/c/chromium/src/+/2108507

Change-Id: Ia0e3d0f5d19994021bcbc94739ea51a802bd5877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120476
Commit-Queue: Mark Brand <markbrand@google.com>
Reviewed-by: default avatarKen Rockot <rockot@google.com>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753565}
parent e971d4fc
...@@ -250,6 +250,14 @@ mojom("gpu_preferences_interface") { ...@@ -250,6 +250,14 @@ mojom("gpu_preferences_interface") {
mojom("vulkan_interface") { mojom("vulkan_interface") {
generate_java = true generate_java = true
# TODO(crbug.com/1062364): This interface code is used by some javascript targets even
# when vulkan isn't enabled, but the C++ fuzzer code will fail to compile if
# the headers aren't available.
if (!enable_vulkan) {
enable_fuzzing = false
}
sources = [ sources = [
"vulkan_info.mojom", "vulkan_info.mojom",
"vulkan_types.mojom", "vulkan_types.mojom",
......
...@@ -596,9 +596,9 @@ template("mojom") { ...@@ -596,9 +596,9 @@ template("mojom") {
write_file("$target_gen_dir/$target_name.deps_sources_list", deps_sources) write_file("$target_gen_dir/$target_name.deps_sources_list", deps_sources)
generate_fuzzing = enable_ipc_fuzzer && (!defined(invoker.enable_fuzzing) || generate_fuzzing =
invoker.enable_fuzzing) && (!defined(invoker.enable_fuzzing) || invoker.enable_fuzzing) &&
(!defined(invoker.testonly) || !invoker.testonly) enable_ipc_fuzzer && (!defined(invoker.testonly) || !invoker.testonly)
if (sources_list != []) { if (sources_list != []) {
parser_target_name = "${target_name}__parser" parser_target_name = "${target_name}__parser"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment