Commit 5c872c1a authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

IDL: Fix invalid extended attributes

An invliad extended attribute [Enabled] was used in IDLs of WebRTC,
and some APIs are visible regardless a runtime enabled feature.
This CL fixes the IDL description and hide them behind a flag.


Bug: 999690, 986069
Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923Reviewed-by: default avatarHarald Alvestrand <hta@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Reviewed-by: default avatarFlorent Castelli <orphis@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693038}
parent 7324a5e4
......@@ -8,5 +8,5 @@ dictionary RTCRtpCodecCapability {
required unsigned long clockRate;
unsigned short channels;
DOMString sdpFmtpLine;
[Enabled=RTCSvcScalabilityMode] sequence<DOMString> scalabilityModes;
[RuntimeEnabled=RTCSvcScalabilityMode] sequence<DOMString> scalabilityModes;
};
......@@ -21,5 +21,5 @@ dictionary RTCRtpEncodingParameters : RTCRtpCodingParameters {
unsigned long maxBitrate;
//TODO(orphis): Missing maxFramerate. https://crbug.com/857047
double scaleResolutionDownBy;
[Enabled=RTCSvcScalabilityMode] DOMString scalabilityMode;
[RuntimeEnabled=RTCSvcScalabilityMode] DOMString scalabilityMode;
};
This is a testharness.js-based test.
FAIL Setting scalabilityMode to a legal value should be accepted assert_equals: expected (string) "L1T3" but got (undefined) undefined
FAIL Sender capabilities should include at least some scalability modes assert_true: expected true got false
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment