Commit 5ce33727 authored by Anders Hartvoll Ruud's avatar Anders Hartvoll Ruud Committed by Commit Bot

[mpc] Make text-decoration properties computed_value_comparable

Bug: 1057072
Change-Id: I1329af49c97d1cd4bec073334c0b8d23645758bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209081
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771543}
parent d1487a1b
...@@ -3550,6 +3550,7 @@ ...@@ -3550,6 +3550,7 @@
affected_by_forced_colors: true, affected_by_forced_colors: true,
valid_for_first_letter: true, valid_for_first_letter: true,
valid_for_cue: true, valid_for_cue: true,
computed_value_comparable: true,
}, },
{ {
name: "text-decoration-line", name: "text-decoration-line",
...@@ -3564,6 +3565,7 @@ ...@@ -3564,6 +3565,7 @@
converter: "ConvertFlags<TextDecoration>", converter: "ConvertFlags<TextDecoration>",
valid_for_first_letter: true, valid_for_first_letter: true,
valid_for_cue: true, valid_for_cue: true,
computed_value_comparable: true,
}, },
{ {
name: "text-decoration-skip-ink", name: "text-decoration-skip-ink",
...@@ -3576,6 +3578,7 @@ ...@@ -3576,6 +3578,7 @@
default_value: "auto", default_value: "auto",
valid_for_first_letter: true, valid_for_first_letter: true,
valid_for_cue: true, valid_for_cue: true,
computed_value_comparable: true,
}, },
{ {
name: "text-decoration-style", name: "text-decoration-style",
...@@ -3587,12 +3590,12 @@ ...@@ -3587,12 +3590,12 @@
default_value: "solid", default_value: "solid",
valid_for_first_letter: true, valid_for_first_letter: true,
valid_for_cue: true, valid_for_cue: true,
computed_value_comparable: true,
}, },
{ {
name: "text-decoration-thickness", name: "text-decoration-thickness",
runtime_flag: "UnderlineOffsetThickness", runtime_flag: "UnderlineOffsetThickness",
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"], property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
# TODO: Move to core/style?
include_paths: ["third_party/blink/renderer/core/style/text_decoration_thickness.h"], include_paths: ["third_party/blink/renderer/core/style/text_decoration_thickness.h"],
inherited: true, inherited: true,
field_group: "*", field_group: "*",
...@@ -3603,6 +3606,7 @@ ...@@ -3603,6 +3606,7 @@
keywords: ["auto", "from-font"], keywords: ["auto", "from-font"],
typedom_types: ["Keyword", "Length", "Percentage"], typedom_types: ["Keyword", "Length", "Percentage"],
valid_for_first_letter: true, valid_for_first_letter: true,
computed_value_comparable: true,
}, },
{ {
name: "text-indent", name: "text-indent",
......
...@@ -156,6 +156,9 @@ const char* length_or_none_examples[] = {"none", "1px", "2px", "5%", nullptr}; ...@@ -156,6 +156,9 @@ const char* length_or_none_examples[] = {"none", "1px", "2px", "5%", nullptr};
const char* length_size_examples[] = {"4px", "1px 2px", "3%", "calc(1% + 1px)", const char* length_size_examples[] = {"4px", "1px 2px", "3%", "calc(1% + 1px)",
nullptr}; nullptr};
const char* line_width_examples[] = {"medium", "thin", "100px", nullptr}; const char* line_width_examples[] = {"medium", "thin", "100px", nullptr};
const char* none_auto_examples[] = {"none", "auto", nullptr};
const char* text_decoration_line_examples[] = {"none", "underline", nullptr};
const char* text_decoration_style_examples[] = {"solid", "dashed", nullptr};
const char* vertical_align_examples[] = {"sub", "super", "1px", "3%", nullptr}; const char* vertical_align_examples[] = {"sub", "super", "1px", "3%", nullptr};
const char* writing_mode_examples[] = {"horizontal-tb", "vertical-rl", nullptr}; const char* writing_mode_examples[] = {"horizontal-tb", "vertical-rl", nullptr};
...@@ -189,6 +192,11 @@ struct ComputedValuesEqualData { ...@@ -189,6 +192,11 @@ struct ComputedValuesEqualData {
{"min-height", length_or_auto_examples}, {"min-height", length_or_auto_examples},
{"min-width", length_or_auto_examples}, {"min-width", length_or_auto_examples},
{"right", length_or_auto_examples}, {"right", length_or_auto_examples},
{"text-decoration-color", color_examples},
{"text-decoration-line", text_decoration_line_examples},
{"text-decoration-skip-ink", none_auto_examples},
{"text-decoration-style", text_decoration_style_examples},
{"text-decoration-thickness", length_or_auto_examples},
{"top", length_or_auto_examples}, {"top", length_or_auto_examples},
{"vertical-align", vertical_align_examples}, {"vertical-align", vertical_align_examples},
{"width", length_or_auto_examples}, {"width", length_or_auto_examples},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment