Commit 5cf007db authored by bustamante's avatar bustamante Committed by Commit bot

Remove "client_version" test from chromium

I cleaned up all the references in our various waterfalls, and this will
remove the test completely.

BUG=578272

Review URL: https://codereview.chromium.org/1640483002

Cr-Commit-Position: refs/heads/master@{#371678}
parent 7dc9e3a5
...@@ -10,16 +10,6 @@ from telemetry import benchmark ...@@ -10,16 +10,6 @@ from telemetry import benchmark
DESKTOP_PLATFORMS = ['mac', 'linux', 'win', 'chromeos'] DESKTOP_PLATFORMS = ['mac', 'linux', 'win', 'chromeos']
WEBVIEW_PLATFORMS = ['android-webview', 'android-webview-shell'] WEBVIEW_PLATFORMS = ['android-webview', 'android-webview-shell']
class ChromeProxyClientVersion(ChromeProxyBenchmark):
tag = 'client_version'
test = measurements.ChromeProxyClientVersion
page_set = pagesets.SyntheticStorySet
@classmethod
def Name(cls):
return 'chrome_proxy_benchmark.client_version.synthetic'
class ChromeProxyClientType(ChromeProxyBenchmark): class ChromeProxyClientType(ChromeProxyBenchmark):
tag = 'client_type' tag = 'client_type'
test = measurements.ChromeProxyClientType test = measurements.ChromeProxyClientType
......
...@@ -241,27 +241,6 @@ class ChromeProxyHTTPFallbackViaHeader(ChromeProxyValidation): ...@@ -241,27 +241,6 @@ class ChromeProxyHTTPFallbackViaHeader(ChromeProxyValidation):
self._metrics.AddResultsForHTTPFallback(tab, results) self._metrics.AddResultsForHTTPFallback(tab, results)
class ChromeProxyClientVersion(ChromeProxyValidation):
"""Correctness measurement for version directives in Chrome-Proxy header.
The test verifies that the version information provided in the Chrome-Proxy
request header overrides any version, if specified, that is provided in the
user agent string.
"""
def __init__(self):
super(ChromeProxyClientVersion, self).__init__(
metrics=metrics.ChromeProxyMetric())
def CustomizeBrowserOptions(self, options):
super(ChromeProxyClientVersion,
self).CustomizeBrowserOptions(options)
options.AppendExtraBrowserArgs('--user-agent="Chrome/32.0.1700.99"')
def AddResults(self, tab, results):
self._metrics.AddResultsForClientVersion(tab, results)
class ChromeProxyClientType(ChromeProxyValidation): class ChromeProxyClientType(ChromeProxyValidation):
"""Correctness measurement for Chrome-Proxy header client type directives.""" """Correctness measurement for Chrome-Proxy header client type directives."""
......
...@@ -170,25 +170,6 @@ class ChromeProxyMetric(network_metrics.NetworkMetric): ...@@ -170,25 +170,6 @@ class ChromeProxyMetric(network_metrics.NetworkMetric):
results.AddValue(scalar.ScalarValue( results.AddValue(scalar.ScalarValue(
results.current_page, 'extra_via_header', 'count', extra_via_count)) results.current_page, 'extra_via_header', 'count', extra_via_count))
def AddResultsForClientVersion(self, tab, results):
via_count = 0
for resp in self.IterResponses(tab):
r = resp.response
if resp.response.status != 200:
raise ChromeProxyMetricException, ('%s: Response is not 200: %d' %
(r.url, r.status))
if not resp.IsValidByViaHeader():
raise ChromeProxyMetricException, ('%s: Response missing via header' %
(r.url))
via_count += 1
if via_count == 0:
raise ChromeProxyMetricException, (
'Expected at least one response through the proxy, but zero such '
'responses were received.')
results.AddValue(scalar.ScalarValue(
results.current_page, 'responses_via_proxy', 'count', via_count))
def GetClientTypeFromRequests(self, tab): def GetClientTypeFromRequests(self, tab):
"""Get the Chrome-Proxy client type value from requests made in this tab. """Get the Chrome-Proxy client type value from requests made in this tab.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment