Skip to content

GitLab

T
tangled
Commit 5cf3408b authored by Aleks Totic's avatar Aleks Totic Committed by Commit Bot
Browse files
Options

[LayoutNG] Rebaseline tests more correct in NG 

004-vertical is removed per discussion on Slack.

svg/zoom/page/zoom-svg-float-border-padding.xml
There is no anti-aliasing in NG for top left corner.

tables/mozilla/bugs/bug2973.html
<td>inside of table<img src=""></td>
NG is consistent with FF/Edge.

Bug: 902591
Change-Id: Ie672601caef16f19914855ba83a2cfe8e58ab5d8
Reviewed-on: https://chromium-review.googlesource.com/c/1323794Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606244}
parent a3dc7158
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 238 deletions
third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
View file @ 5cf3408b
...@@ -283,7 +283,6 @@ crbug.com/591099 fast/replaced/replaced-breaking.html [ Failure Pass ] ...@@ -283,7 +283,6 @@ crbug.com/591099 fast/replaced/replaced-breaking.html [ Failure Pass ]
crbug.com/591099 fast/scroll-snap/snaps-after-keyboard-scrolling-rtl.html [ Failure ] crbug.com/591099 fast/scroll-snap/snaps-after-keyboard-scrolling-rtl.html [ Failure ]
crbug.com/591099 fast/scrolling/editor-command-scroll-page-scale.html [ Pass ] crbug.com/591099 fast/scrolling/editor-command-scroll-page-scale.html [ Pass ]
crbug.com/591099 fast/sub-pixel/sub-pixel-border-2.html [ Failure ] crbug.com/591099 fast/sub-pixel/sub-pixel-border-2.html [ Failure ]
crbug.com/591099 fast/table/border-collapsing/004-vertical.html [ Failure ]
crbug.com/591099 fast/table/height-percent-test-vertical.html [ Failure ] crbug.com/591099 fast/table/height-percent-test-vertical.html [ Failure ]
crbug.com/591099 fast/table/unbreakable-images-quirk.html [ Failure ] crbug.com/591099 fast/table/unbreakable-images-quirk.html [ Failure ]
crbug.com/591099 fast/text/descent-clip-in-scaled-page.html [ Failure ] crbug.com/591099 fast/text/descent-clip-in-scaled-page.html [ Failure ]
...@@ -370,14 +369,14 @@ crbug.com/591099 scrollbars/auto-scrollbar-fit-content.html [ Failure ] ...@@ -370,14 +369,14 @@ crbug.com/591099 scrollbars/auto-scrollbar-fit-content.html [ Failure ]
crbug.com/591099 storage/indexeddb/mozilla/test_objectStore_openKeyCursor.html [ Pass ] crbug.com/591099 storage/indexeddb/mozilla/test_objectStore_openKeyCursor.html [ Pass ]
crbug.com/591099 storage/indexeddb/objectstore-cursor.html [ Pass ] crbug.com/591099 storage/indexeddb/objectstore-cursor.html [ Pass ]
crbug.com/591099 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Failure ] crbug.com/591099 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Failure ]
crbug.com/591099 svg/zoom/page/zoom-svg-float-border-padding.xml [ Failure ] crbug.com/591099 svg/zoom/page/zoom-svg-float-border-padding.xml [ Pass ]
crbug.com/591099 svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml [ Failure ] crbug.com/591099 svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml [ Failure ]
crbug.com/591099 svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml [ Failure ] crbug.com/591099 svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml [ Failure ]
crbug.com/591099 svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml [ Failure ] crbug.com/591099 svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml [ Failure ]
crbug.com/591099 tables/mozilla/bugs/bug101674.html [ Failure ] crbug.com/591099 tables/mozilla/bugs/bug101674.html [ Failure ]
crbug.com/591099 tables/mozilla/bugs/bug14159-1.html [ Pass ] crbug.com/591099 tables/mozilla/bugs/bug14159-1.html [ Pass ]
crbug.com/591099 tables/mozilla/bugs/bug23235.html [ Failure ] crbug.com/591099 tables/mozilla/bugs/bug23235.html [ Failure ]
crbug.com/591099 tables/mozilla/bugs/bug2973.html [ Failure ] crbug.com/591099 tables/mozilla/bugs/bug2973.html [ Pass ]
crbug.com/591099 tables/mozilla/bugs/bug50695-2.html [ Failure ] crbug.com/591099 tables/mozilla/bugs/bug50695-2.html [ Failure ]
crbug.com/591099 tables/mozilla/bugs/bug55527.html [ Failure ] crbug.com/591099 tables/mozilla/bugs/bug55527.html [ Failure ]
crbug.com/591099 virtual/android/fullscreen/video-controls-timeline.html [ Failure Pass ] crbug.com/591099 virtual/android/fullscreen/video-controls-timeline.html [ Failure Pass ]
......
third_party/WebKit/LayoutTests/SmokeTests
View file @ 5cf3408b
...@@ -746,7 +746,6 @@ fast/sub-pixel/client-and-offset-width.html ...@@ -746,7 +746,6 @@ fast/sub-pixel/client-and-offset-width.html
fast/sub-pixel/vertical-align-middle-overflow.html fast/sub-pixel/vertical-align-middle-overflow.html
fast/table/assert-autotablelayout-maxlogicalwidth.html fast/table/assert-autotablelayout-maxlogicalwidth.html
fast/table/border-collapsing/004.html fast/table/border-collapsing/004.html
fast/table/border-collapsing/004-vertical.html
fast/table/border-collapsing/dynamic-border-width-change.html fast/table/border-collapsing/dynamic-border-width-change.html
fast/table/columngroup-inside-columngroup.html fast/table/columngroup-inside-columngroup.html
fast/table/crash-anonymous-table-computeLogicalWidth.html fast/table/crash-anonymous-table-computeLogicalWidth.html
......
third_party/WebKit/LayoutTests/TestExpectations
View file @ 5cf3408b
...@@ -5096,7 +5096,6 @@ crbug.com/824539 [ Android ] fast/selectors/018.html [ Failure ] ...@@ -5096,7 +5096,6 @@ crbug.com/824539 [ Android ] fast/selectors/018.html [ Failure ]
crbug.com/824539 [ Android ] fast/selectors/061.html [ Failure ] crbug.com/824539 [ Android ] fast/selectors/061.html [ Failure ]
crbug.com/824539 [ Android ] fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html [ Crash Failure ] crbug.com/824539 [ Android ] fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html [ Crash Failure ]
crbug.com/824539 [ Android ] fast/speech/scripted/speechrecognition-re-restart.html [ Failure ] crbug.com/824539 [ Android ] fast/speech/scripted/speechrecognition-re-restart.html [ Failure ]
crbug.com/824539 [ Android ] fast/table/border-collapsing/004-vertical.html [ Failure ]
crbug.com/824539 [ Android ] fast/table/border-collapsing/004.html [ Failure ] crbug.com/824539 [ Android ] fast/table/border-collapsing/004.html [ Failure ]
crbug.com/824539 [ Android ] fast/text/stroking-decorations.html [ Failure ] crbug.com/824539 [ Android ] fast/text/stroking-decorations.html [ Failure ]
crbug.com/824539 [ Android ] fast/text/international/001.html [ Failure ] crbug.com/824539 [ Android ] fast/text/international/001.html [ Failure ]
...@@ -5283,6 +5282,10 @@ crbug.com/869492 virtual/video-surface-layer/external/wpt/feature-policy/experim ...@@ -5283,6 +5282,10 @@ crbug.com/869492 virtual/video-surface-layer/external/wpt/feature-policy/experim
crbug.com/896924 http/tests/inspector-protocol/network/interception-multiclient.js [ Skip ] crbug.com/896924 http/tests/inspector-protocol/network/interception-multiclient.js [ Skip ]
crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ] crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ]
# New rebaselines because LayoutNG is more correct
crbug.com/902591 [ Linux ] svg/zoom/page/zoom-svg-float-border-padding.xml [ Failure ]
crbug.com/902591 [ Linux ] tables/mozilla/bugs/bug2973.html [ Failure ]
# Sheriff 2018-09-13 # Sheriff 2018-09-13
crbug.com/883591 [ Android ] fullscreen/full-screen-inline-split-crash.html [ Pass Crash ] crbug.com/883591 [ Android ] fullscreen/full-screen-inline-split-crash.html [ Pass Crash ]
......
third_party/WebKit/LayoutTests/fast/table/border-collapsing/004-vertical.html deleted 100644 → 0
View file @ a3dc7158
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">
<html><head>
<title>Table Border Models</title>
<style type="text/css">
body { overflow: hidden; }
TABLE { margin: 1em; width: auto; border: medium solid blue; }
TD { border: thin solid green; padding: 5px; }
TH { border: medium solid purple; padding: 5px; }
TABLE.one, TABLE.two { border-spacing: 1em; }
TABLE.one { border-collapse: collapse; }
TABLE.two { border-collapse: separate; }
TABLE.three { border-collapse: separate; border-spacing: 0 0.5em; }
TABLE.four { border-collapse: separate; border-spacing: 0.5em 0; }
TABLE.five { border-collapse: separate; }
TABLE.five, TABLE.five TD, TABLE.five TH, TABLE.five CAPTION { border: none; }
TABLE.five TR, TABLE.five COL, TABLE.five COLGROUP, TABLE.five TBODY, TABLE.five THEAD
{ border: medium solid red; }
</style>
</head>
<body>
<h1>Table Border Models</h1>
<p>This tests tests the <a
href="http://www.w3.org/TR/REC-CSS2/tables.html#borders">CSS2 spec
rules on table borders</a>. The styles applied here are:</p>
<pre>
TABLE { margin: 1em; border: medium solid blue; }
TD { border: thin solid green; padding: 5px; }
TH { border: medium solid purple; padding: 5px; }
TABLE.one, TABLE.two { border-spacing: 1em; }
TABLE.one { border-collapse: collapse; }
TABLE.two { border-collapse: separate; }
TABLE.three { border-collapse: separate; border-spacing: 0 0.5em; }
TABLE.four { border-collapse: separate; border-spacing: 0.5em 0; }
TABLE.five { border-collapse: separate; }
TABLE.five, TABLE.five TD, TABLE.five TH { border: none; }
TABLE.five TR, TABLE.five COL, TABLE.five COLGROUP, TABLE.five TBODY, TABLE.five THEAD
{ border: medium solid red; }
</pre>
<div style="-webkit-writing-mode: vertical-rl;">
<table class="one">
<tr>
<th>Header One</th>
<th>Header Two</th>
<th>Header Three</th>
</tr>
<tr>
<td>
This table uses the collapsed borders model.
</td>
<td>
This means that elements within the cell have no border-spacing.
</td>
<td>
Since it has collapsed borders, the borders on the header cells,
on all sides, should be medium solid purple.
</td>
</tr>
<tr>
<td>
The border of the table itself should be medium solid blue, except
where header cells override the border.
</td>
<td>
The borders that I haven't already mentioned (all the other internal
ones) should be thin solid green.
</td>
<td>
This table should have a 1em margin around all edges. This margin
is measured from the <em>middle</em> of its border.
</td>
</tr>
</table>
<table class="two">
<tr>
<th>Header One</th>
<th>Header Two</th>
<th>Header Three</th>
</tr>
<tr>
<td>
This table uses the separated borders model.
</td>
<td>
This means that elements within the cell have border-spacing of 1em.
</td>
<td>
The borders on the header cells,
on all sides, should be medium solid purple.
</td>
</tr>
<tr>
<td>
The border of the table itself should be medium solid blue.
</td>
<td>
The borders of other cells should be thin solid green.
</td>
<td>
This table should have a 1em margin around all edges. This margin
is measured from the <em>outer edge</em> of its border.
</td>
</tr>
</table>
<table class="three">
<tr>
<th>Header One</th>
<th>Header Two</th>
<th>Header Three</th>
</tr>
<tr>
<td>
This table uses the separated borders model.
</td>
<td>
Elements within the cell have horizontal border-spacing (i.e., width of
vertical lines) of 0 and vertical
border-spacing (i.e., height of horizontal lines) of 0.5em.
</td>
<td>
The borders on the header cells,
on all sides, should be medium solid purple.
</td>
</tr>
<tr>
<td>
The border of the table itself should be medium solid blue.
The borders of other cells should be thin solid green.
</td>
<td>
This table should have a 1em margin around all edges. This margin
is measured from the <em>outer edge</em> of its border.
</td>
<td>
The table should not be wider than the room available for it unless
that space is very small. Because of its margins, the width of the
table should be less than 100%.
</td>
</tr>
</table>
<table class="four">
<tr>
<th>Header One</th>
<th>Header Two</th>
<th>Header Three</th>
</tr>
<tr>
<td>
This table uses the separated borders model.
</td>
<td>
Elements within the cell have horizontal border-spacing of 0.5em and vertical
border-spacing of 0.
</td>
<td>
The borders on the header cells,
on all sides, should be medium solid purple.
</td>
</tr>
<tr>
<td>
The border of the table itself should be medium solid blue.
The borders of other cells should be thin solid green.
</td>
<td>
This table should have a 1em margin around all edges. This margin
is measured from the <em>outer edge</em> of its border.
</td>
<td>
The table should not be wider than the room available for it unless
that space is very small. Because of its margins, the width of the
table should be less than 100%.
</td>
</tr>
</table>
<table class="five">
<caption>
This is the caption.
</caption>
<colgroup>
<col>
</colgroup>
<colgroup>
<col>
<col>
</colgroup>
<thead>
<tr>
<th>Header One</th>
<th>Header Two</th>
<th>Header Three</th>
</tr>
</thead>
<tbody>
<tr>
<td>
This table uses the separated borders model.
</td>
<td>
This means that borders are allowed only on table elements or table
cell elements.
</td>
<td>
They are not allowed on elements that represent rows,
row-groups, columns, or column-groups.
</td>
</tr>
<tr>
<td>
There should be no borders at all on this table!
</td>
<td>
If there are any borders shown that are not medium solid red, then
the problem is something other than what this test is testing.
</td>
<td>
This table should have a 1em margin around all edges. This margin
is measured from the <em>outer edge</em> of its border.
</td>
</tr>
</tbody>
</table>
</div>
</body></html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment