Disable tabbing through the <pin-keyboard> buttons
This makes the buttons of the <pin-keyboard> element untabbable. It affects the Chrome OS smart card SAML PIN screen, the quick_unlock PIN setup screen, the quick_unlock login keypad in the WebUI user pod. This should NOT be an accessibility regression, since these buttons don't provide any extra functionality: i.e., the PIN can still be directly entered into the input field via other methods. The change was also approved by the a11y team (see the attached bug). This should also resolve some a11y bugs related to these buttons, because their normal behavior wasn't quite a11y-friendly (for example, it's hard to deal with the focus, for which it makes sense to keep it at the pressed button, but at the same time this confuses ChromeVox and prevents it from saying "bullet"). Bug: 1043194 Test: start SAML login using a smart card, proceed to the PIN dialog, try to press Tab a few times, verify that the buttons of the PIN keyboard ("1", "2", etc., "backspace") don't get selected Change-Id: Ic70ac0d4550d969f2f25d79e2a08a432e3b29c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066910Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#744324}
Showing
Please register or sign in to comment