Commit 5d385f5e authored by Erik Chen's avatar Erik Chen Committed by Commit Bot

Avoid referencing undead RenderWidget in FrameInputHandlerImpl.

This CL is a refactor with no intended behavior change.

FrameInputHandlerImpl only needs the RenderWidget to perform coordinate
transforms. This functionality is now exposed on RenderView, and undead
RenderWidget will no longer exist in the future.

Bug: 912193
Change-Id: Ibc3b0528c1539dd286558de52a7141161d46fe29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838536
Auto-Submit: Erik Chen <erikchen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703062}
parent 028c29fb
......@@ -286,7 +286,7 @@ void FrameInputHandlerImpl::SelectRange(const gfx::Point& base,
if (!render_frame_)
return;
RenderWidget* window_widget = render_frame_->render_view()->GetWidget();
RenderWidget* window_widget = render_frame_->GetLocalRootRenderWidget();
HandlingState handling_state(render_frame_, UpdateState::kIsSelectingRange);
render_frame_->GetWebFrame()->SelectRange(
window_widget->ConvertWindowPointToViewport(base),
......@@ -383,7 +383,7 @@ void FrameInputHandlerImpl::MoveRangeSelectionExtent(const gfx::Point& extent) {
return;
HandlingState handling_state(render_frame_, UpdateState::kIsSelectingRange);
render_frame_->GetWebFrame()->MoveRangeSelectionExtent(
render_frame_->render_view()->GetWidget()->ConvertWindowPointToViewport(
render_frame_->GetLocalRootRenderWidget()->ConvertWindowPointToViewport(
extent));
}
......@@ -418,7 +418,7 @@ void FrameInputHandlerImpl::MoveCaret(const gfx::Point& point) {
return;
render_frame_->GetWebFrame()->MoveCaretSelection(
render_frame_->render_view()->GetWidget()->ConvertWindowPointToViewport(
render_frame_->GetLocalRootRenderWidget()->ConvertWindowPointToViewport(
point));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment