Commit 5d41571e authored by Quinten Yearsley's avatar Quinten Yearsley Committed by Commit Bot

Remove out-of-date comment in Win.setup_environ_for_server

Win.setup_environ_for_server copies a few more environment variables
for apache on Windows. I checked (in patchset one of this CL) whether
these are still necessary, and they are. This CL would just update
the comment.

Change-Id: Iae3b9c4e379cc77457ca6bc66cee4a95c9a46018
Reviewed-on: https://chromium-review.googlesource.com/590579Reviewed-by: default avatarJeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491767}
parent 9e21c73c
...@@ -155,16 +155,12 @@ class WinPort(base.Port): ...@@ -155,16 +155,12 @@ class WinPort(base.Port):
self._crash_service = None self._crash_service = None
def setup_environ_for_server(self): def setup_environ_for_server(self):
# A few extra environment variables are required for Apache on Windows.
env = super(WinPort, self).setup_environ_for_server() env = super(WinPort, self).setup_environ_for_server()
# FIXME: This is a temporary hack to get the cr-win bot online until
# someone from the cr-win port can take a look.
# TODO(qyearsley): Remove this in a separate CL.
apache_envvars = ['SYSTEMDRIVE', 'SYSTEMROOT', 'TEMP', 'TMP'] apache_envvars = ['SYSTEMDRIVE', 'SYSTEMROOT', 'TEMP', 'TMP']
for key, value in self.host.environ.copy().items(): for key, value in self.host.environ.copy().items():
if key not in env and key in apache_envvars: if key not in env and key in apache_envvars:
env[key] = value env[key] = value
return env return env
def check_build(self, needs_http, printer): def check_build(self, needs_http, printer):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment