Commit 5d4f2af9 authored by jri's avatar jri Committed by Commit bot

Adding histogram to count number of RTTs for handshake when confirmation is required.

BUG=

Review URL: https://codereview.chromium.org/502243002

Cr-Commit-Position: refs/heads/master@{#292182}
parent 78025b19
...@@ -242,6 +242,11 @@ QuicClientSession::~QuicClientSession() { ...@@ -242,6 +242,11 @@ QuicClientSession::~QuicClientSession() {
} else { } else {
UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectRandomPortForHTTP", UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectRandomPortForHTTP",
round_trip_handshakes, 0, 3, 4); round_trip_handshakes, 0, 3, 4);
if (require_confirmation_) {
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Net.QuicSession.ConnectRandomPortRequiringConfirmationForHTTP",
round_trip_handshakes, 0, 3, 4);
}
} }
} else { } else {
if (port_selected) { if (port_selected) {
...@@ -250,6 +255,11 @@ QuicClientSession::~QuicClientSession() { ...@@ -250,6 +255,11 @@ QuicClientSession::~QuicClientSession() {
} else { } else {
UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectRandomPortForHTTPS", UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectRandomPortForHTTPS",
round_trip_handshakes, 0, 3, 4); round_trip_handshakes, 0, 3, 4);
if (require_confirmation_) {
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Net.QuicSession.ConnectRandomPortRequiringConfirmationForHTTPS",
round_trip_handshakes, 0, 3, 4);
}
} }
} }
const QuicConnectionStats stats = connection()->GetStats(); const QuicConnectionStats stats = connection()->GetStats();
......
...@@ -16243,6 +16243,17 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -16243,6 +16243,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>The IP Address family of this connection, as seen locally.</summary> <summary>The IP Address family of this connection, as seen locally.</summary>
</histogram> </histogram>
<histogram name="Net.QuicSession.ConnectRandomPortRequiringConfirmation"
units="RTTs">
<owner>jri@chromium.org</owner>
<summary>
Samples of the number of round-trips needed by a QUIC connection before a
request could be sent by the client, when handshake confirmation was
required. (The operating system randomly selected a source port for the
connection.)
</summary>
</histogram>
<histogram name="Net.QuicSession.CreationError" enum="QuicSessionErrorCodes"> <histogram name="Net.QuicSession.CreationError" enum="QuicSessionErrorCodes">
<owner>jar@chromium.org</owner> <owner>jar@chromium.org</owner>
<owner>rch@chromium.org</owner> <owner>rch@chromium.org</owner>
...@@ -54264,6 +54275,17 @@ To add a new entry, add it with any value and run test to compute valid value. ...@@ -54264,6 +54275,17 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="ShortcutsProvider.QueryIndexTime"/> <affected-histogram name="ShortcutsProvider.QueryIndexTime"/>
</histogram_suffixes> </histogram_suffixes>
<histogram_suffixes name="QuicConnectionType" separator="">
<owner>rch@chromium.org</owner>
<suffix name="ForHTTP" label="Only insecure HTTP connections are counted."/>
<suffix name="ForHTTPS" label="Only secure HTTPS connections are counted."/>
<affected-histogram name="Net.QuicSession.ConnectRandomPort"/>
<affected-histogram
name="Net.QuicSession.ConnectRandomPortRequiringConfirmation"/>
<affected-histogram name="Net.QuicSession.ConnectSelectPort"/>
<affected-histogram name="Net.QuicSession.HandshakeRoundTrips"/>
</histogram_suffixes>
<histogram_suffixes name="QuicPortSelection" separator=""> <histogram_suffixes name="QuicPortSelection" separator="">
<owner>rch@chromium.org</owner> <owner>rch@chromium.org</owner>
<suffix name="SelectPort" <suffix name="SelectPort"
...@@ -54275,15 +54297,6 @@ To add a new entry, add it with any value and run test to compute valid value. ...@@ -54275,15 +54297,6 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Net.QuicSession.Connect"/> <affected-histogram name="Net.QuicSession.Connect"/>
</histogram_suffixes> </histogram_suffixes>
<histogram_suffixes name="QuicRttCount" separator="">
<owner>rch@chromium.org</owner>
<suffix name="ForHTTP" label="Only insecure HTTP connections are counted."/>
<suffix name="ForHTTPS" label="Only secure HTTPS connections are counted."/>
<affected-histogram name="Net.QuicSession.ConnectRandomPort"/>
<affected-histogram name="Net.QuicSession.ConnectSelectPort"/>
<affected-histogram name="Net.QuicSession.HandshakeRoundTrips"/>
</histogram_suffixes>
<histogram_suffixes name="RemoteProcessWarmStartFast" separator=""> <histogram_suffixes name="RemoteProcessWarmStartFast" separator="">
<suffix name="" label="Normal start."/> <suffix name="" label="Normal start."/>
<suffix name="Fast" <suffix name="Fast"
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment