Commit 5d54d8d4 authored by Jungshik Shin's avatar Jungshik Shin Committed by Commit Bot

Mark string-prototype-properties as Skip for now

string-prototype-properties has an errorneous expectation. When
a fix for crbug.com/v8/7958 was landed, that led to a test failure.
See
https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64/25165/layout-test-results/fast/js/string-prototype-properties-pretty-diff.html

This CL marks the test for Skip and fix the expectation manually.

Once the fix for bug v8:7958 [1] is landed and rolled to Chromium,
the Skip line can be dropped.

[1] https://chromium-review.googlesource.com/c/v8/v8/+/1154247

TBR=gsathya@chromium.org

Bug: v8:7958
Test: fast/js/string-prototype-properties
Change-Id: I7402f8a896a073a897d44a16e4ec76ea1fda61fc
Reviewed-on: https://chromium-review.googlesource.com/1154289Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578926}
parent fa54afc3
......@@ -2508,6 +2508,9 @@ crbug.com/v8/7753 inspector-protocol/debugger/message-channel-async-stack.js [ S
crbug.com/v8/7753 inspector-protocol/worker/worker-on-message-async-stacks.js [ Skip ]
crbug.com/v8/7753 inspector-protocol/worker/worker-post-message-async-stacks.js [ Skip ]
# TODO(ftang,jshin) Remove once v8 is rolled to include a fix for v8/7958.
crbug.com/v8/7958 fast/js/string-prototype-properties.html [ Skip ]
# TODO(chrishtr) uncomment ones marked crbug.com/591500 after fixing crbug.com/665259.
crbug.com/591500 [ Win10 ] printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]
crbug.com/591500 [ Win10 ] virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]
......
......@@ -20,7 +20,7 @@ PASS String.prototype.substr.call(undefined, 1, 3) threw exception TypeError: St
PASS String.prototype.substring.call(undefined, 1, 3) threw exception TypeError: String.prototype.substring called on null or undefined.
PASS String.prototype.toLowerCase.call(undefined) threw exception TypeError: String.prototype.toLowerCase called on null or undefined.
PASS String.prototype.toUpperCase.call(undefined) threw exception TypeError: String.prototype.toUpperCase called on null or undefined.
PASS String.prototype.localeCompare.call(undefined, '1224') threw exception TypeError: Method invoked on undefined or null value..
PASS String.prototype.localeCompare.call(undefined, '1224') threw exception TypeError: String.prototype.localeCompare called on null or undefined.
PASS String.prototype.toLocaleLowerCase.call(undefined) threw exception TypeError: String.prototype.toLocaleLowerCase called on null or undefined.
PASS String.prototype.toLocaleUpperCase.call(undefined) threw exception TypeError: String.prototype.toLocaleUpperCase called on null or undefined.
PASS String.prototype.trim.call(undefined) threw exception TypeError: String.prototype.trim called on null or undefined.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment