Commit 5d65e587 authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Update PasswordSpecificsData proto to contain information about

compromised passwords and mutes.

Bug: 1137775
Change-Id: If9f2d4e7b130318a1f1ff6c12f4ef04fb0e005af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550045
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829656}
parent 8c306840
......@@ -115,6 +115,26 @@ message PasswordSpecificsData {
// Time when the credential was last used. Amount of microseconds since 1601.
optional int64 date_last_used = 18;
message PasswordIssues {
message PasswordIssue {
// Timestamp set by a client detecting the issue for the first time.
// Number of microseconds since Windows epoch (1601).
optional uint64 date_first_detection_microseconds = 1;
// Whether the issue was muted by user.
optional bool is_muted = 2;
}
optional PasswordIssue leaked_password_issue = 1;
optional PasswordIssue reused_password_issue = 2;
optional PasswordIssue weak_password_issue = 3;
optional PasswordIssue phished_password_issue = 4;
}
// Set if an issue was detected that puts this password at risk. All the
// clients are expected to clear the field when the password value is updated.
// 'reused' part can be additionally reset when the analysis on the entire
// password store is completed.
optional PasswordIssues password_issues = 19;
}
// Contains the password specifics metadata which simplifies its lookup.
......
......@@ -721,6 +721,21 @@ VISIT_PROTO_FIELDS(const sync_pb::PasswordSpecificsData& proto) {
VISIT(display_name);
VISIT(avatar_url);
VISIT(federation_url);
VISIT(date_last_used);
VISIT(password_issues);
}
VISIT_PROTO_FIELDS(const sync_pb::PasswordSpecificsData_PasswordIssues& proto) {
VISIT(leaked_password_issue);
VISIT(reused_password_issue);
VISIT(weak_password_issue);
VISIT(phished_password_issue);
}
VISIT_PROTO_FIELDS(
const sync_pb::PasswordSpecificsData_PasswordIssues_PasswordIssue& proto) {
VISIT(date_first_detection_microseconds);
VISIT(is_muted);
}
VISIT_PROTO_FIELDS(const sync_pb::PasswordSpecificsMetadata& proto) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment