prerender: Rename function to FindHostToActivate for clarity.

Bug: 1132746
Change-Id: Iee24aa91d115e315a56224857ede961452261df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633221
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844476}

content/browser/prerender/prerender_host_registry.cc

@@ -41,7 +41,7 @@ void PrerenderHostRegistry::AbandonHost(const GURL& prerendering_url) {
   prerender_host_by_url_.erase(prerendering_url);
 }
 
-std::unique_ptr<PrerenderHost> PrerenderHostRegistry::SelectForNavigation(
+std::unique_ptr<PrerenderHost> PrerenderHostRegistry::FindHostToActivate(
     const GURL& navigation_url,
     FrameTreeNode& frame_tree_node) {
   RenderFrameHostImpl* render_frame_host = frame_tree_node.current_frame_host();

content/browser/prerender/prerender_host_registry.h

@@ -47,7 +47,7 @@ class CONTENT_EXPORT PrerenderHostRegistry {
 
   // Selects the host to activate for a navigation for the given FrameTreeNode.
   // Returns nullptr if it's not found or not ready for activation yet.
-  std::unique_ptr<PrerenderHost> SelectForNavigation(
+  std::unique_ptr<PrerenderHost> FindHostToActivate(
       const GURL& navigation_url,
       FrameTreeNode& frame_tree_node);
 

content/browser/prerender/prerender_host_registry_unittest.cc

@@ -75,7 +75,7 @@ TEST_F(PrerenderHostRegistryTest, CreateAndStartHost) {
   // the prerendered page.
   prerender_host->DidFinishNavigation(nullptr);
 
-  EXPECT_TRUE(registry->SelectForNavigation(
+  EXPECT_TRUE(registry->FindHostToActivate(
       kPrerenderingUrl, *render_frame_host->frame_tree_node()));
   EXPECT_EQ(registry->FindHostByUrlForTesting(kPrerenderingUrl), nullptr);
 }
@@ -113,7 +113,7 @@ TEST_F(PrerenderHostRegistryTest, CreateAndStartHostForSameURL) {
   // the prerendered page.
   prerender_host1->DidFinishNavigation(nullptr);
 
-  EXPECT_TRUE(registry->SelectForNavigation(
+  EXPECT_TRUE(registry->FindHostToActivate(
       kPrerenderingUrl, *render_frame_host->frame_tree_node()));
   EXPECT_EQ(registry->FindHostByUrlForTesting(kPrerenderingUrl), nullptr);
 }
@@ -150,7 +150,7 @@ TEST_F(PrerenderHostRegistryTest, CreateAndStartHostForDifferentURLs) {
   prerender_host2->DidFinishNavigation(nullptr);
 
   // Select the first host.
-  EXPECT_TRUE(registry->SelectForNavigation(
+  EXPECT_TRUE(registry->FindHostToActivate(
       kPrerenderingUrl1, *render_frame_host->frame_tree_node()));
   EXPECT_EQ(registry->FindHostByUrlForTesting(kPrerenderingUrl1), nullptr);
   // The second host should still be findable.
@@ -158,12 +158,12 @@ TEST_F(PrerenderHostRegistryTest, CreateAndStartHostForDifferentURLs) {
             prerender_host2);
 
   // Select the second host.
-  EXPECT_TRUE(registry->SelectForNavigation(
+  EXPECT_TRUE(registry->FindHostToActivate(
       kPrerenderingUrl2, *render_frame_host->frame_tree_node()));
   EXPECT_EQ(registry->FindHostByUrlForTesting(kPrerenderingUrl2), nullptr);
 }
 
-TEST_F(PrerenderHostRegistryTest, SelectForNavigationBeforeReadyForActivation) {
+TEST_F(PrerenderHostRegistryTest, FindHostToActivateBeforeReadyForActivation) {
   std::unique_ptr<TestWebContents> web_contents =
       CreateWebContents(GURL("https://example.com/"));
   RenderFrameHostImpl* render_frame_host = web_contents->GetMainFrame();
@@ -183,7 +183,7 @@ TEST_F(PrerenderHostRegistryTest, SelectForNavigationBeforeReadyForActivation) {
   // The prerender host is not ready for activation yet, so the registry
   // shouldn't select the host and instead should abandon it.
   ASSERT_FALSE(prerender_host->is_ready_for_activation());
-  EXPECT_FALSE(registry->SelectForNavigation(
+  EXPECT_FALSE(registry->FindHostToActivate(
       kPrerenderingUrl, *render_frame_host->frame_tree_node()));
   EXPECT_EQ(registry->FindHostByUrlForTesting(kPrerenderingUrl), nullptr);
 }

content/browser/renderer_host/navigation_request.cc

@@ -1552,8 +1552,8 @@ void NavigationRequest::BeginNavigation() {
         storage_partition_impl->GetPrerenderHostRegistry();
     DCHECK(prerender_host_registry);
     std::unique_ptr<PrerenderHost> prerender_host =
-        prerender_host_registry->SelectForNavigation(common_params_->url,
-                                                     *frame_tree_node_);
+        prerender_host_registry->FindHostToActivate(common_params_->url,
+                                                    *frame_tree_node_);
     switch (blink::features::kPrerender2Param.Get()) {
       case blink::features::Prerender2ActivationMode::kEnabled:
         // If `prerender_host_` exists, this navigation will activate the