Commit 5d77f2b5 authored by Ryan Sleevi's avatar Ryan Sleevi Committed by Commit Bot

No longer explicitly initialize a CertVerifier in Cronet

Support for file-based persistence was removed in r571588,
so its no longer necessary for Cronet to explicitly create
a CertVerifier to guarantee it is a CachingCertVerifier.

Bug: 590875
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I23e9e6db12225a7474ce589d9333595729108f1c
Reviewed-on: https://chromium-review.googlesource.com/1169822Reviewed-by: default avatarHelen Li <xunjieli@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582330}
parent dab9c033
......@@ -583,17 +583,8 @@ void URLRequestContextConfig::ConfigureURLRequestContextBuilder(
ParseAndSetExperimentalOptions(context_builder, &session_params, net_log);
context_builder->set_http_network_session_params(session_params);
std::unique_ptr<net::CertVerifier> cert_verifier;
if (mock_cert_verifier) {
// Because |context_builder| expects CachingCertVerifier, wrap
// |mock_cert_verifier| into a CachingCertVerifier.
cert_verifier = std::make_unique<net::CachingCertVerifier>(
std::move(mock_cert_verifier));
} else {
// net::CertVerifier::CreateDefault() returns a CachingCertVerifier.
cert_verifier = net::CertVerifier::CreateDefault();
}
context_builder->SetCertVerifier(std::move(cert_verifier));
if (mock_cert_verifier)
context_builder->SetCertVerifier(std::move(mock_cert_verifier));
// Certificate Transparency is intentionally ignored in Cronet.
// See //net/docs/certificate-transparency.md for more details.
context_builder->set_ct_verifier(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment