Commit 5d92ceeb authored by Manuel Rego Casasnovas's avatar Manuel Rego Casasnovas Committed by Commit Bot

Fix mistake at MarkContainerChainForOverflowRecalcIfNeeded()

In r738875 we stopped marking ancestors if overflow recalc flags
were already present, however by mistake the code was checking
SelfNeedsLayoutOverflowRecalc() instead of
ChildNeedsLayoutOverflowRecalc().

This improves the performance in
perf_tests/shadow_dom/v1-small-deep-distribution.html.

BUG=1051342,941180

Change-Id: Ie94432dd6f207b5abc20132a85ee677a7994a9d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055084Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742690}
parent 24f37c34
...@@ -2014,7 +2014,7 @@ void LayoutObject::MarkContainerChainForOverflowRecalcIfNeeded( ...@@ -2014,7 +2014,7 @@ void LayoutObject::MarkContainerChainForOverflowRecalcIfNeeded(
bool already_needs_layout_overflow_recalc = false; bool already_needs_layout_overflow_recalc = false;
if (mark_container_chain_layout_overflow_recalc) { if (mark_container_chain_layout_overflow_recalc) {
already_needs_layout_overflow_recalc = already_needs_layout_overflow_recalc =
object->SelfNeedsLayoutOverflowRecalc(); object->ChildNeedsLayoutOverflowRecalc();
if (!already_needs_layout_overflow_recalc) if (!already_needs_layout_overflow_recalc)
object->SetChildNeedsLayoutOverflowRecalc(); object->SetChildNeedsLayoutOverflowRecalc();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment