Disabling flaky tests on ChromeOS

As a result of replacing OSMesa with SwiftShader for running browser_tests recently, 4 tests have become flaky on ChromeOS: SiteDetailsBrowserTest.IsolateExtensions ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureMultipleSelectionTest ExtensionApiNewTabTest.Tabs PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation This cl temporarily disables these 4 tests on ChromeOs until we can find a proper fix for them. TBR=vasilii@chromium.org rdevlin.cronin@chromium.org hidehiko@chromium.org TBR_REASON="Making the linux-chromeos-rel bot less flaky" Bug: chromium:870372 chromium:870322 chromium:870319 chromium:671891 Change-Id: I55fdd44622f7fac13dafaa19699904178e37d1fb Reviewed-on: https://chromium-review.googlesource.com/1161202 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580324}

Disabling flaky tests on ChromeOS
As a result of replacing OSMesa with SwiftShader for running browser_tests recently, 4 tests have become flaky on ChromeOS: SiteDetailsBrowserTest.IsolateExtensions ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureMultipleSelectionTest ExtensionApiNewTabTest.Tabs PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation This cl temporarily disables these 4 tests on ChromeOs until we can find a proper fix for them. TBR=vasilii@chromium.org rdevlin.cronin@chromium.org hidehiko@chromium.org TBR_REASON="Making the linux-chromeos-rel bot less flaky" Bug: chromium:870372 chromium:870322 chromium:870319 chromium:671891 Change-Id: I55fdd44622f7fac13dafaa19699904178e37d1fb Reviewed-on: https://chromium-review.googlesource.com/1161202 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580324}
5da0d0d1 · Alexis Hetu · Commit Bot · 4052d411 · 5da0d0d1 · 5da0d0d1
Commit 5da0d0d1 authored Aug 02, 2018 by Alexis Hetu Committed by Commit Bot Aug 02, 2018
4 changed files
--- a/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc
+++ b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc
@@ -142,8 +142,16 @@ IN_PROC_BROWSER_TEST_F(ArcVoiceInteractionArcHomeServiceTest,
  ASSERT_EQ(base::UTF16ToUTF8(child->children[0]->text), "1");
 }

+// Flaky on chromeos: http://crbug.com/870319
+#if defined(OS_CHROMEOS)
+#define MAYBE_VoiceInteractionStructureMultipleSelectionTest \
+  DISABLED_VoiceInteractionStructureMultipleSelectionTest
+#else
+#define MAYBE_VoiceInteractionStructureMultipleSelectionTest \
+  VoiceInteractionStructureMultipleSelectionTest
+#endif
 IN_PROC_BROWSER_TEST_F(ArcVoiceInteractionArcHomeServiceTest,
-                       VoiceInteractionStructureMultipleSelectionTest) {
+                       MAYBE_VoiceInteractionStructureMultipleSelectionTest) {
  auto result = GetVoiceInteractionStructure(
      "<html>"
      "  <body>"

--- a/chrome/browser/extensions/extension_tabs_apitest.cc
+++ b/chrome/browser/extensions/extension_tabs_apitest.cc
@@ -50,7 +50,13 @@ class ExtensionApiNewTabTest : public ExtensionApiTabTest {
  }
 };

-IN_PROC_BROWSER_TEST_F(ExtensionApiNewTabTest, Tabs) {
+// Flaky on chromeos: http://crbug.com/870322
+#if defined(OS_CHROMEOS)
+#define MAYBE_Tabs DISABLED_Tabs
+#else
+#define MAYBE_Tabs Tabs
+#endif
+IN_PROC_BROWSER_TEST_F(ExtensionApiNewTabTest, MAYBE_Tabs) {
  // The test creates a tab and checks that the URL of the new tab
  // is that of the new tab page.  Make sure the pref that controls
  // this is set.

--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -807,8 +807,16 @@ IN_PROC_BROWSER_TEST_P(PasswordManagerBrowserTestWithViewsFeature,
  EXPECT_TRUE(prompt_observer->IsSavePromptShownAutomatically());
 }

-IN_PROC_BROWSER_TEST_P(PasswordManagerBrowserTestWithViewsFeature,
-                       PromptForFetchSubmitWithoutNavigation) {
+// Flaky on chromeos: http://crbug.com/870372
+#if defined(OS_CHROMEOS)
+#define MAYBE_PromptForFetchSubmitWithoutNavigation \
+  DISABLED_PromptForFetchSubmitWithoutNavigation
+#else
+#define MAYBE_PromptForFetchSubmitWithoutNavigation \
+  PromptForFetchSubmitWithoutNavigation
+#endif
+IN_PROC_BROWSER_TEST_P(PasswordManagerBrowserTestWithViewsFeature,
+                       MAYBE_PromptForFetchSubmitWithoutNavigation) {
  NavigateToFile("/password/password_fetch_submit.html");

  // Need to pay attention for a message that XHR has finished since there

--- a/chrome/browser/site_details_browsertest.cc
+++ b/chrome/browser/site_details_browsertest.cc
@@ -579,8 +579,8 @@ IN_PROC_BROWSER_TEST_F(SiteDetailsBrowserTest, DISABLED_ManyIframes) {
                  ElementsAre(Bucket(12, 1), Bucket(29, 1), Bucket(68, 1))));
 }

-// Flaky on Windows and Mac. crbug.com/671891
-#if defined(OS_WIN) || defined(OS_MACOSX)
+// Flaky on Windows, Mac and ChromeOS. crbug.com/671891
+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
 #define MAYBE_IsolateExtensions DISABLED_IsolateExtensions
 #else
 #define MAYBE_IsolateExtensions IsolateExtensions