[NTP Cleanup] Remove @private annotations from local NTP

The @private annotations don't really serve a purpose.

Also, clean up some const ordering, missing JSDoc, and spelling errors.

Change-Id: Ib074aef2a51d226b84d1a00da6482eb607bb285f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679438
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672757}

chrome/browser/resources/local_ntp/customize.js

@@ -168,10 +168,23 @@ customize.MENU_ENTRIES = {
   RESTORE_DEFAULT: 3,
 };
 
+/**
+ * The semi-transparent, gradient overlay for the custom background. Intended
+ * to improve readability of NTP elements/text.
+ * @type {string}
+ * @const
+ */
 customize.CUSTOM_BACKGROUND_OVERLAY =
     'linear-gradient(rgba(0, 0, 0, 0), rgba(0, 0, 0, 0.3))';
 
-// These shound match the corresponding values in local_ntp.js, that control the
+/**
+ * Number of rows in the custom background dialog to preload.
+ * @type {number}
+ * @const
+ */
+customize.ROWS_TO_PRELOAD = 3;
+
+// These should match the corresponding values in local_ntp.js, that control the
 // mv-notice element.
 customize.delayedHideNotification = -1;
 customize.NOTIFICATION_TIMEOUT = 10000;
@@ -188,24 +201,15 @@ customize.builtTiles = false;
  */
 customize.selectedBackgroundTile = null;
 
-/**
- * Number of rows in the custom background dialog to preload.
- * @type {number}
- * @const
- */
-customize.ROWS_TO_PRELOAD = 3;
-
 /**
  * Called when the error notification should be shown.
  * @type {?Function}
- * @private
  */
 customize.showErrorNotification = null;
 
 /**
  * Called when the custom link notification should be hidden.
  * @type {?Function}
- * @private
  */
 customize.hideCustomLinkNotification = null;
 
@@ -213,14 +217,12 @@ customize.hideCustomLinkNotification = null;
  * The currently selected submenu (i.e. Background, Shortcuts, etc.) in the
  * richer picker. Corresponds to the submenu's button element in the sidebar.
  * @type {?Element}
- * @private
  */
 customize.richerPicker_selectedSubmenu = null;
 
 /**
  * The preselected options for Shortcuts in the richer picker.
  * @type {Object}
- * @private
  */
 customize.preselectedShortcutOptions = {
   // Contains the selected type's DOM element, i.e. either custom links or most visited.
@@ -231,7 +233,6 @@ customize.preselectedShortcutOptions = {
 /**
  * The currently selected options for Shortcuts in the richer picker.
  * @type {Object}
- * @private
  */
 customize.selectedShortcutOptions = {
   // Contains the preselected type's DOM element, i.e. either custom links or most visited.
@@ -889,7 +890,7 @@ customize.removeSelectedState = function(tile) {
 };
 
 /**
- * Show dialog for selecting an image. Image data should previous have been
+ * Show dialog for selecting an image. Image data should previously have been
  * loaded into collImg via
  * chrome-search://local-ntp/ntp-background-images.js?collection_id=<collection_id>
  * @param {string} dialogTitle The title to be displayed at the top of the
@@ -1080,7 +1081,6 @@ customize.fadeInImageTile = function(tile, imageUrl, countLoad) {
 /**
  * Load the NTPBackgroundCollections script. It'll create a global
  * variable name "coll" which is a dict of background collections data.
- * @private
  */
 customize.loadChromeBackgrounds = function() {
   const collElement = $('ntp-collection-loader');

chrome/browser/resources/local_ntp/local_ntp.js

@@ -345,7 +345,6 @@ function getThemeBackgroundInfo() {
  *
  * @param {!Object} info Theme background information.
  * @return {boolean} Whether the chips should be dark.
- * @private
  */
 function getUseDarkChips(info) {
   return info.usingDarkMode && !info.imageUrl;
@@ -353,7 +352,6 @@ function getUseDarkChips(info) {
 
 /**
  * Updates the NTP based on the current theme.
- * @private
  */
 function renderTheme() {
   const info = getThemeBackgroundInfo();
@@ -454,7 +452,6 @@ function renderTheme() {
 
 /**
  * Sends the current theme info to the most visited iframe.
- * @private
  */
 function sendThemeInfoToMostVisitedIframe() {
   const info = getThemeBackgroundInfo();
@@ -483,7 +480,6 @@ function sendThemeInfoToMostVisitedIframe() {
 
 /**
  * Sends the current theme info to the edit custom link iframe.
- * @private
  */
 function sendThemeInfoToEditCustomLinkIframe() {
   if (!configData.isGooglePage) {
@@ -504,7 +500,6 @@ function sendThemeInfoToEditCustomLinkIframe() {
 /**
  * Updates the OneGoogleBar (if it is loaded) based on the current theme.
  * TODO(crbug.com/918582): Add support for OGB dark mode.
- * @private
  */
 function renderOneGoogleBarTheme() {
   if (!window.gbar) {
@@ -524,7 +519,6 @@ function renderOneGoogleBarTheme() {
 
 /**
  * Callback for embeddedSearch.newTabPage.onthemechange.
- * @private
  */
 function onThemeChange() {
   // Save the current dark mode state to check if dark mode has changed.
@@ -545,7 +539,6 @@ function onThemeChange() {
 /**
  * Updates the NTP style according to theme.
  * @param {Object} themeInfo The information about the theme.
- * @private
  */
 function setCustomThemeStyle(themeInfo) {
   let textColor = '';
@@ -571,7 +564,6 @@ function setCustomThemeStyle(themeInfo) {
  * @param {string} url The URL of the attribution image, if any.
  * @param {string} themeBackgroundAlignment The alignment of the theme
  *     background image. This is used to compute the attribution's alignment.
- * @private
  */
 function updateThemeAttribution(url, themeBackgroundAlignment) {
   if (!url) {
@@ -597,7 +589,6 @@ function updateThemeAttribution(url, themeBackgroundAlignment) {
 /**
  * Sets the visibility of the theme attribution.
  * @param {boolean} show True to show the attribution.
- * @private
  */
 function setAttributionVisibility_(show) {
   $(IDS.ATTRIBUTION).style.display = show ? '' : 'none';
@@ -607,7 +598,6 @@ function setAttributionVisibility_(show) {
  * Converts an Array of color components into RGBA format "rgba(R,G,B,A)".
  * @param {Array<number>} color Array of rgba color components.
  * @return {string} CSS color in RGBA format.
- * @private
  */
 function convertToRGBAColor(color) {
   return 'rgba(' + color[0] + ',' + color[1] + ',' + color[2] + ',' +