Skip to content

GitLab

T
tangled
Commit 5daba75f authored by Sigurd Schneider's avatar Sigurd Schneider Committed by Commit Bot
Browse files
Options

[devtools] Add regression test 

This test adds a regression test for breakpoints in inline scripts
with #sourceURL=.

Bug: chromium:1017738
Change-Id: Id5c58cf7e8346879b1ad37a79262d4516708b580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878652
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709452}
parent ef81e5d0
Hide whitespace changes
Inline Side-by-side
Showing with 119 additions and 0 deletions
third_party/blink/web_tests/http/tests/devtools/startup/sources/debugger/resources/script-formatter-breakpoints-inline-with-sourceURL.html 0 → 100644
View file @ 5daba75f
<html>
<head>
<script>
function functionInInlineScriptWithSourceURL() {
console.log("Hello!");
let x = 10;
return x;
}
//# sourceURL=named-inline-script.js
</script>
</head>
<body onload="testRunner.inspectSecondaryWindow()">
</body>
</html>
third_party/blink/web_tests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-inline-with-sourceURL-expected.txt 0 → 100644
View file @ 5daba75f
Tests the script formatting is working with breakpoints for inline scripts with #sourceURL=.
Running: testSetup
Running: testBreakpointsInOriginalAndFormattedSource
Script execution paused.
Breakpoint sidebar pane while paused in raw
named-inline-script.js:5 console.log("Hello!");
Script execution resumed.
Script execution paused.
Breakpoint sidebar pane while paused in pretty printed
named-inline-script.js:formatted:3 console.log("Hello!");
Breakpoint sidebar pane while paused after removing breakpoint in pretty printed and closing pretty printed
No breakpoints
Breakpoint sidebar pane while paused in original script again
named-inline-script.js:5 console.log("Hello!");
Script execution resumed.
third_party/blink/web_tests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-inline-with-sourceURL.js 0 → 100644
View file @ 5daba75f
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
(async function() {
await TestRunner.setupStartupTest('resources/script-formatter-breakpoints-inline-with-sourceURL.html');
TestRunner.addResult(`Tests the script formatting is working with breakpoints for inline scripts with #sourceURL=.\n`);
await TestRunner.loadModule('sources_test_runner');
await TestRunner.showPanel('sources');
Bindings.breakpointManager._storage._breakpoints = new Map();
let panel = UI.panels.sources;
let scriptFormatter;
let sourceFrame;
let formattedSourceFrame;
SourcesTestRunner.runDebuggerTestSuite([
function testSetup(next) {
SourcesTestRunner.scriptFormatter().then(function(sf) {
scriptFormatter = sf;
next();
});
},
async function testBreakpointsInOriginalAndFormattedSource(next) {
SourcesTestRunner.showScriptSource('named-inline-script.js', didShowScriptSource);
function didShowScriptSource(frame) {
sourceFrame = frame;
SourcesTestRunner.setBreakpoint(sourceFrame, 4, '', true); // Lines here are zero based.
Promise.all([SourcesTestRunner.waitBreakpointSidebarPane(true), SourcesTestRunner.waitUntilPausedPromise()])
.then(pausedInFunctionInInlineScriptWithSourceURL);
TestRunner.evaluateInPageWithTimeout('functionInInlineScriptWithSourceURL()');
}
function pausedInFunctionInInlineScriptWithSourceURL(callFrames) {
SourcesTestRunner.dumpBreakpointSidebarPane('while paused in raw');
SourcesTestRunner.resumeExecution(resumed);
}
function resumed() {
TestRunner.addSniffer(
Sources.ScriptFormatterEditorAction.prototype, '_updateButton', uiSourceCodeScriptFormatted);
scriptFormatter._toggleFormatScriptSource();
}
function uiSourceCodeScriptFormatted() {
// There should be a breakpoint in functionInInlineScriptWithSourceURL although script is pretty-printed.
Promise.all([SourcesTestRunner.waitBreakpointSidebarPane(true), SourcesTestRunner.waitUntilPausedPromise()])
.then(pausedInFunctionInInlineScriptWithSourceURLAgain);
TestRunner.evaluateInPageWithTimeout('functionInInlineScriptWithSourceURL()');
}
function pausedInFunctionInInlineScriptWithSourceURLAgain(callFrames) {
SourcesTestRunner.dumpBreakpointSidebarPane('while paused in pretty printed');
SourcesTestRunner.showScriptSource('named-inline-script.js:formatted', didShowFormattedScriptSource);
}
function didShowFormattedScriptSource(frame) {
formattedSourceFrame = frame;
SourcesTestRunner.removeBreakpoint(formattedSourceFrame, 2); // Lines here are zero based.
Sources.sourceFormatter.discardFormattedUISourceCode(formattedSourceFrame.uiSourceCode());
SourcesTestRunner.waitBreakpointSidebarPane().then(onBreakpointsUpdated);
}
function onBreakpointsUpdated() {
SourcesTestRunner.dumpBreakpointSidebarPane('while paused after removing breakpoint in pretty printed and closing pretty printed');
SourcesTestRunner.setBreakpoint(sourceFrame, 4, '', true); // Lines here are zero based.
Promise.all([SourcesTestRunner.waitBreakpointSidebarPane(true), SourcesTestRunner.waitUntilPausedPromise()])
.then(pausedInFunctionInInlineScriptWithSourceURLThirdTime);
TestRunner.evaluateInPageWithTimeout('functionInInlineScriptWithSourceURL()');
}
function pausedInFunctionInInlineScriptWithSourceURLThirdTime() {
SourcesTestRunner.dumpBreakpointSidebarPane('while paused in original script again');
SourcesTestRunner.removeBreakpoint(sourceFrame, 4); // Lines here are zero based.
SourcesTestRunner.resumeExecution(next);
}
}
]);
})();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment