Commit 5db13be7 authored by Ehsan Chiniforooshan's avatar Ehsan Chiniforooshan Committed by Commit Bot

Telemetry: fix rendering_unittest

I changed the metric name in
https://chromium-review.googlesource.com/c/catapult/+/1181702.

This CL comments out the test for that metric so that the Catapult
roller is unblocked. After Catapult is rolled to after the renaming
CL the test should be re-enabled.

Bug: 876276
Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a

NOTRY=true # CQ flake

Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a
Reviewed-on: https://chromium-review.googlesource.com/1183694Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Reviewed-by: default avatarAnnie Sullivan <sullivan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585012}
parent 020ec575
......@@ -44,12 +44,15 @@ class RenderingUnitTest(page_test_test_case.PageTestTestCase):
else:
num_samples[histogram_name] = current_num_samples
# Check the existence of cores_per_second metrics.
for thread_group in RENDERING_THREAD_GROUPS:
# We should have at least two sample values for each metric, since
# pageset_repeat is 2.
self.assertGreater(
num_samples.get('cores_per_second_%s_thread' % thread_group, 0), 1)
# Check the existence of thread_*_cpu_time_per_second_tbmv2 metrics.
# TODO(crbug.com/876276): The following block should be uncommented after
# crrev.com/c/1181702 is rolled.
#
# for thread_group in RENDERING_THREAD_GROUPS:
# # We should have at least two sample values for each metric, since
# # pageset_repeat is 2.
# histograme_name = 'thread_%s_cpu_time_per_second_tbmv2' % thread_group
# self.assertGreater(num_samples.get(histogram_name, 0), 1)
# Check the existence of some of the legacy metrics.
self.assertGreater(num_samples.get('frame_times', 0), 1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment