Prepending switches by :: to not clash with safe_browsing::switches
There is both a ::safe_browsing::switches namespace and a ::switches namespace. If you inside the safe_browsing namespace write |switches| it will map to ::safe_browsing::switches if that namespace is known to exist. In some jumbo builds where many cc files are compiled together the compiler knows about that namespace and chooses it wrongly. There is a style guide instruction to not use sub namespace names that are identical to top level namespace names, probably for this reason, so maybe all sub namespaces named |switches| should be given new names, the same way that has already happened to some |features| namespaces. This patch is a small trivial fix, add a :: prefix to |switches| to make it clear which |switches| namespace is intended. Change-Id: I2f39ca26b2174455b94eeadd8b6cfb756248a6c9 Reviewed-on: https://chromium-review.googlesource.com/c/1278729Reviewed-by:Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#599595}
Showing
Please register or sign in to comment