Commit 5db4bede authored by torne's avatar torne Committed by Commit bot

android_webview: don't suppress debuggerd crash handling.

WebView was incorrectly suppressing debuggerd crash handling after
breakpad microdumps were triggered on all user builds of android, as the
process type was not empty as expected for the Chrome browser process.
This went unnoticed as the normal behaviour was still in place for
userdebug/eng builds. Fix by also treating "webview" process type as a
browser process in the crash component.

BUG=481420

Review URL: https://codereview.chromium.org/1105293003

Cr-Commit-Position: refs/heads/master@{#327277}
parent dfcd13ed
......@@ -730,11 +730,12 @@ void InitMicrodumpCrashHandlerIfNecessary(const std::string& process_type) {
VLOG(1) << "Enabling microdumps crash handler (process_type:"
<< process_type << ")";
DCHECK(!g_microdump);
bool is_browser_process = process_type.empty() || process_type == "webview";
g_microdump = new ExceptionHandler(
MinidumpDescriptor(MinidumpDescriptor::kMicrodumpOnConsole),
NULL,
MicrodumpCrashDone,
reinterpret_cast<void*>(process_type.empty()),
reinterpret_cast<void*>(is_browser_process),
true, // Install handlers.
-1); // Server file descriptor. -1 for in-process.
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment