Skip to content

GitLab

T
tangled
Commit 5dbb2c75 authored by Alex Danilo's avatar Alex Danilo Committed by Chromium LUCI CQ
Browse files
Options

[files-progress] Remove unused strings 

Strings being removed are:
 IDS_FILE_BROWSER_TO_FOLDER_NAME
 IDS_FILE_BROWSER_MOVED_TO
 IDS_FILE_BROWSER_MOVED
 IDS_FILE_BROWSER_COPIED_TO
 IDS_FILE_BROWSER_COPIED

Only two of the strings (IDS_FILE_BROWSER_COPIED and
IDS_FILE_BROWSER_MOVED) had an associated SHA1 file for the PNG
image, remove those.

No change in functionality.

Bug: 953308, 1093603
Change-Id: Ia73a1eafa7e13a2b58f28d7e411a0e6e23c58cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605944
Auto-Submit: Alex Danilo <adanilo@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839692}
parent f1ea96a6
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 30 deletions
chrome/browser/chromeos/file_manager/file_manager_string_util.cc
View file @ 5dbb2c75
......@@ -476,14 +476,10 @@ std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() {
IDS_FILE_BROWSER_CONFLICT_DIALOG_MESSAGE);
SET_STRING("CONFLICT_DIALOG_REPLACE",
IDS_FILE_BROWSER_CONFLICT_DIALOG_REPLACE);
SET_STRING("COPIED", IDS_FILE_BROWSER_COPIED);
SET_STRING("COPIED_TO", IDS_FILE_BROWSER_COPIED_TO);
SET_STRING("COPY_BUTTON_LABEL", IDS_FILE_BROWSER_COPY_BUTTON_LABEL);
SET_STRING("COPY_FILESYSTEM_ERROR", IDS_FILE_BROWSER_COPY_FILESYSTEM_ERROR);
// TODO (crbug/1093603): Clean up after FilesTransferDetails launch.
SET_STRING("COPY_FILE_NAME", IDS_FILE_BROWSER_COPY_FILE_NAME);
SET_STRING("COPY_ITEMS_REMAINING", IDS_FILE_BROWSER_COPY_ITEMS_REMAINING);
// TODO: End.
SET_STRING("COPY_FILE_NAME_LONG", IDS_FILE_BROWSER_COPY_FILE_NAME_LONG);
SET_STRING("COPY_ITEMS_REMAINING_LONG",
IDS_FILE_BROWSER_COPY_ITEMS_REMAINING_LONG);
......@@ -718,12 +714,8 @@ std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() {
IDS_FILE_BROWSER_METADATA_BOX_YEAR_RECORDED);
SET_STRING("MOUNT_ARCHIVE", IDS_FILE_BROWSER_MOUNT_ARCHIVE);
SET_STRING("MOVE_FILESYSTEM_ERROR", IDS_FILE_BROWSER_MOVE_FILESYSTEM_ERROR);
SET_STRING("MOVED", IDS_FILE_BROWSER_MOVED);
SET_STRING("MOVED_TO", IDS_FILE_BROWSER_MOVED_TO);
// TODO (crbug/1093603): Clean up after FilesTransferDetails launch.
SET_STRING("MOVE_FILE_NAME", IDS_FILE_BROWSER_MOVE_FILE_NAME);
SET_STRING("MOVE_ITEMS_REMAINING", IDS_FILE_BROWSER_MOVE_ITEMS_REMAINING);
// TODO: End.
SET_STRING("MOVE_FILE_NAME_LONG", IDS_FILE_BROWSER_MOVE_FILE_NAME_LONG);
SET_STRING("MOVE_ITEMS_REMAINING_LONG",
IDS_FILE_BROWSER_MOVE_ITEMS_REMAINING_LONG);
......@@ -849,7 +841,6 @@ std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() {
SET_STRING("SELECT_ALL_COMMAND_LABEL",
IDS_FILE_BROWSER_SELECT_ALL_COMMAND_LABEL);
SET_STRING("TASKS_BUTTON_LABEL", IDS_FILE_BROWSER_TASKS_BUTTON_LABEL);
SET_STRING("TO_FOLDER_NAME", IDS_FILE_BROWSER_TO_FOLDER_NAME);
SET_STRING("TOGGLE_HIDDEN_FILES_COMMAND_LABEL",
IDS_FILE_BROWSER_TOGGLE_HIDDEN_FILES_COMMAND_LABEL);
SET_STRING("SHARE_BUTTON_LABEL", IDS_FILE_BROWSER_SHARE_BUTTON_LABEL);
......
ui/chromeos/file_manager_strings.grdp
View file @ 5dbb2c75
......@@ -736,20 +736,12 @@
<message name="IDS_FILE_BROWSER_CLOUD_IMPORT_ITEMS_REMAINING" desc="File Manager status message.">
Importing <ph name="FILE_COUNT">$1<ex>5</ex></ph> files...
</message>
<message name="IDS_FILE_BROWSER_COPIED" desc="File Manager status message.">
Copied.
</message>
<message name="IDS_FILE_BROWSER_COPIED_TO" desc="File Manager status message.">
Copied to <ph name="FOLDER_NAME">$1<ex>images</ex></ph>.
</message>
<!-- TODO (crbug/1093603): Clean up after FilesTransferDetails launch. -->
<message name="IDS_FILE_BROWSER_COPY_FILE_NAME" desc="File Manager status message.">
Copying <ph name="FILE_NAME">$1<ex>movie.avi</ex></ph>...
</message>
<message name="IDS_FILE_BROWSER_COPY_ITEMS_REMAINING" desc="File Manager status message. 'Item' is used here as a generic term for file or directory.">
Copying <ph name="NUMBER_OF_ITEMS">$1<ex>3</ex></ph> items...
</message>
<!-- TODO: End. -->
<message name="IDS_FILE_BROWSER_COPY_FILE_NAME_LONG" desc="File Manager status message including destination folder when copying one file.">
Copying <ph name="FILE_NAME">$1<ex>movie.avi</ex></ph> to <ph name="FOLDER_NAME">$2<ex>images</ex></ph>
</message>
......@@ -791,14 +783,12 @@
<message name="IDS_FILE_BROWSER_FILE_MOVED" desc="File Manager status message. 'Item' is used here as a generic term for file or directory.">
<ph name="FILE_NAME">$1<ex>big.xz</ex></ph> moved.
</message>
<!-- TODO (crbug/1093603): Clean up after FilesTransferDetails launch. -->
<message name="IDS_FILE_BROWSER_MOVE_FILE_NAME" desc="File Manager status message.">
Moving <ph name="FILE_NAME">$1<ex>movie.avi</ex></ph>...
</message>
<message name="IDS_FILE_BROWSER_MOVE_ITEMS_REMAINING" desc="File Manager status message. 'Item' is used here as a generic term for file or directory.">
Moving <ph name="NUMBER_OF_ITEMS">$1<ex>3</ex></ph> items...
</message>
<!-- TODO: End. -->
<message name="IDS_FILE_BROWSER_MOVE_FILE_NAME_LONG" desc="File Manager status message including destination folder when moving one file.">
Moving <ph name="FILE_NAME">$1<ex>movie.avi</ex></ph> to <ph name="FOLDER_NAME">$2<ex>images</ex></ph>
</message>
......@@ -817,15 +807,6 @@
<message name="IDS_FILE_BROWSER_MOVE_UNEXPECTED_ERROR" desc="File Manager error message.">
Move failed, unexpected error: <ph name="ERROR_MESSAGE">$1<ex>Could not move</ex></ph>
</message>
<message name="IDS_FILE_BROWSER_MOVED" desc="File Manager status message.">
Moved.
</message>
<message name="IDS_FILE_BROWSER_MOVED_TO" desc="File Manager status message.">
Moved to <ph name="FOLDER_NAME">$1<ex>images</ex></ph>.
</message>
<message name="IDS_FILE_BROWSER_TO_FOLDER_NAME" desc="File Manager status message.">
To <ph name="FOLDER_NAME">$1<ex>images</ex></ph>
</message>
<message name="IDS_FILE_BROWSER_ZIP_FILE_NAME" desc="File Manager status message.">
Zipping <ph name="FILE_NAME">$1<ex>movie.avi</ex></ph>...
</message>
......
ui/chromeos/file_manager_strings_grdp/IDS_FILE_BROWSER_COPIED.png.sha1 deleted 100644 → 0
View file @ f1ea96a6
5eca46944ee40bc7d3a7697113763a49dee4318f
\ No newline at end of file
ui/chromeos/file_manager_strings_grdp/IDS_FILE_BROWSER_MOVED.png.sha1 deleted 100644 → 0
View file @ f1ea96a6
72034fcb299c4592b43bf720ea43a72e4a6f0855
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment