Commit 5dd87b6e authored by rbpotter's avatar rbpotter Committed by Commit Bot

Print Preview: Remove destination list tooltips

These tooltips do not exist in the original UI and were accidentally
added to the new one. Since the text is identical to the displayed
title, there is no reason for them to exist. Remove them by
renaming the "title" property to "listName", as the title attribute
is used to create tooltips.

Bug: 867838
Change-Id: Ie2e6dfa5bd38f9a7c2aea80b2742a46abd866aa1
Reviewed-on: https://chromium-review.googlesource.com/1152451
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578911}
parent df15c8e7
......@@ -170,14 +170,14 @@
<print-preview-destination-list id="recentList"
destinations="[[recentDestinationList_]]"
search-query="[[searchQuery_]]"
title="$i18n{recentDestinationsTitle}"
list-name="$i18n{recentDestinationsTitle}"
on-destination-selected="onDestinationSelected_">
</print-preview-destination-list>
<print-preview-destination-list id="printList"
destinations="[[destinations_]]"
has-action-link loading-destinations="[[loadingDestinations_]]"
search-query="[[searchQuery_]]"
title="$i18n{printDestinationsTitle}"
list-name="$i18n{printDestinationsTitle}"
on-destination-selected="onDestinationSelected_">
</print-preview-destination-list>
</div>
......
......@@ -81,7 +81,7 @@
}
</style>
<header>
<h4 class="title">[[title]]</h4>
<h4 class="title">[[listName]]</h4>
<span class="total" hidden$="[[!showDestinationsTotal_]]">
[[i18n('destinationCount', matchingDestinations_.length)]]
</span>
......
......@@ -29,8 +29,7 @@ Polymer({
value: false,
},
/** @type {boolean} */
title: String,
listName: String,
/** @private {!Array<!print_preview.Destination>} */
matchingDestinations_: {
......
......@@ -50,12 +50,11 @@ cr.define('destination_list_test', function() {
];
// Set up list
list = document.createElement('print-preview-destination-list');
document.body.appendChild(list);
list.hasActionLink = true;
list.loadingDestinations = false;
list.title = 'test';
document.body.innerHTML = `
<print-preview-destination-list id="testList" has-action-link=true
loading-destinations=false list-name="test">
</print-preview-destination-list>`;
list = document.body.querySelector('#testList');
list.searchQuery = null;
list.destinations = destinations;
Polymer.dom.flush();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment