media/gpu/vaapi_wrapper: Remove "const scoped_refptr<T>&" at BlitSurface()

The Chromium smart pointer guidelines [1] says "don't pass or return a
smart pointer by reference". This CL removes
"const scoped_refptr<T>&" at VaapiWrapper::BlitSurface().

[1] https://www.chromium.org/developers/smart-pointer-guidelines

Bug: 1020668
Test: run vda_tests on octopus

Change-Id: Ic9e042e066c7dbe3257d973a5c03586ea3f05766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975491
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726734}

media/gpu/vaapi/vaapi_image_processor.cc

@@ -181,9 +181,9 @@ void VaapiImageProcessor::Process(scoped_refptr<VideoFrame> input_frame,
     return;
   }
   // VA-API performs pixel format conversion and scaling without any filters.
-  if (vaapi_wrapper_->BlitSurface(
-          std::move(src_va_surface), std::move(dst_va_surface),
-          input_frame->visible_rect(), output_frame->visible_rect())) {
+  if (vaapi_wrapper_->BlitSurface(*src_va_surface, *dst_va_surface,
+                                  input_frame->visible_rect(),
+                                  output_frame->visible_rect())) {
     // Failed to execute BlitSurface(). Since VaapiWrapper has invoked
     // ReportToUMA(), calling error_cb_ here is not needed.
     return;

media/gpu/vaapi/vaapi_jpeg_encode_accelerator.cc

@@ -181,7 +181,7 @@ void VaapiJpegEncodeAccelerator::Encoder::EncodeWithDmaBufTask(
   auto blit_surface =
       base::MakeRefCounted<VASurface>(va_surface_id_, input_size, va_format,
                                       base::DoNothing() /* release_cb */);
-  if (!vpp_vaapi_wrapper_->BlitSurface(input_surface, blit_surface)) {
+  if (!vpp_vaapi_wrapper_->BlitSurface(*input_surface, *blit_surface)) {
     VLOGF(1) << "Failed to blit surfaces";
     notify_error_cb_.Run(task_id, PLATFORM_FAILURE);
     return;

media/gpu/vaapi/vaapi_mjpeg_decode_accelerator.cc

@@ -384,7 +384,7 @@ bool VaapiMjpegDecodeAccelerator::OutputPictureVppOnTaskRunner(
     VLOGF(1) << "Cannot sync VPP input surface";
     return false;
   }
-  if (!vpp_vaapi_wrapper_->BlitSurface(src_surface, dst_surface)) {
+  if (!vpp_vaapi_wrapper_->BlitSurface(*src_surface, *dst_surface)) {
     VLOGF(1) << "Cannot convert decoded image into output buffer";
     return false;
   }

media/gpu/vaapi/vaapi_picture_native_pixmap.cc

@@ -38,7 +38,7 @@ VaapiPictureNativePixmap::~VaapiPictureNativePixmap() = default;
 bool VaapiPictureNativePixmap::DownloadFromSurface(
     scoped_refptr<VASurface> va_surface) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  return vaapi_wrapper_->BlitSurface(std::move(va_surface), va_surface_);
+  return vaapi_wrapper_->BlitSurface(*va_surface, *va_surface_);
 }
 
 bool VaapiPictureNativePixmap::AllowOverlay() const {

media/gpu/vaapi/vaapi_video_encode_accelerator.cc

@@ -657,7 +657,7 @@ std::unique_ptr<VaapiEncodeJob> VaapiVideoEncodeAccelerator::CreateEncodeJob(
         kVaSurfaceFormat, base::BindOnce(vpp_va_surface_release_cb_));
     available_vpp_va_surface_ids_.pop_back();
     // Crop/Scale the visible area of |frame| -> |blit_visible_rect|.
-    if (!vpp_vaapi_wrapper_->BlitSurface(input_surface, blit_surface,
+    if (!vpp_vaapi_wrapper_->BlitSurface(*input_surface, *blit_surface,
                                          frame->visible_rect(),
                                          blit_visible_rect_)) {
       NOTIFY_ERROR(

media/gpu/vaapi/vaapi_wrapper.cc

@@ -1923,8 +1923,8 @@ void VaapiWrapper::DestroyVABuffers() {
   va_buffers_.clear();
 }
 
-bool VaapiWrapper::BlitSurface(const scoped_refptr<VASurface>& va_surface_src,
-                               const scoped_refptr<VASurface>& va_surface_dest,
+bool VaapiWrapper::BlitSurface(const VASurface& va_surface_src,
+                               const VASurface& va_surface_dest,
                                base::Optional<gfx::Rect> src_rect,
                                base::Optional<gfx::Rect> dest_rect) {
   base::AutoLock auto_lock(*va_lock_);
@@ -1952,9 +1952,9 @@ bool VaapiWrapper::BlitSurface(const scoped_refptr<VASurface>& va_surface_src,
 
     memset(pipeline_param, 0, sizeof *pipeline_param);
     if (!src_rect)
-      src_rect.emplace(gfx::Rect(va_surface_src->size()));
+      src_rect.emplace(gfx::Rect(va_surface_src.size()));
     if (!dest_rect)
-      dest_rect.emplace(gfx::Rect(va_surface_dest->size()));
+      dest_rect.emplace(gfx::Rect(va_surface_dest.size()));
 
     VARectangle input_region;
     input_region.x = src_rect->x();
@@ -1962,7 +1962,7 @@ bool VaapiWrapper::BlitSurface(const scoped_refptr<VASurface>& va_surface_src,
     input_region.width = src_rect->width();
     input_region.height = src_rect->height();
     pipeline_param->surface_region = &input_region;
-    pipeline_param->surface = va_surface_src->id();
+    pipeline_param->surface = va_surface_src.id();
     pipeline_param->surface_color_standard = VAProcColorStandardNone;
 
     VARectangle output_region;
@@ -1979,7 +1979,7 @@ bool VaapiWrapper::BlitSurface(const scoped_refptr<VASurface>& va_surface_src,
   }
 
   VA_SUCCESS_OR_RETURN(
-      vaBeginPicture(va_display_, va_context_id_, va_surface_dest->id()),
+      vaBeginPicture(va_display_, va_context_id_, va_surface_dest.id()),
       "vaBeginPicture", false);
 
   VA_SUCCESS_OR_RETURN(

media/gpu/vaapi/vaapi_wrapper.h

@@ -379,8 +379,8 @@ class MEDIA_GPU_EXPORT VaapiWrapper
   // |va_surface_dest| applying pixel format conversion, cropping and scaling
   // if needed. |src_rect| and |dest_rect| are optional. They can be used to
   // specify the area used in the blit.
-  bool BlitSurface(const scoped_refptr<VASurface>& va_surface_src,
-                   const scoped_refptr<VASurface>& va_surface_dest,
+  bool BlitSurface(const VASurface& va_surface_src,
+                   const VASurface& va_surface_dest,
                    base::Optional<gfx::Rect> src_rect = base::nullopt,
                    base::Optional<gfx::Rect> dest_rect = base::nullopt);