Commit 5e296bf8 authored by Xing Liu's avatar Xing Liu Committed by Commit Bot

Chime: Fix an issue that renderer processes call ChimeInstall.

Only the browser process needs to initialize Chime SDK through
ChimeDelegate. Renderer process will crash and hang since we try to
access the shared preference in a sandbox process.

TBR=dtrainor@chromium.org

Bug: 1146954
Change-Id: I21f84b4b507423d1672d6778f782666c2a384950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527530Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826671}
parent 5a379a99
......@@ -136,6 +136,8 @@ public class ChromeApplication extends SplitCompatApplication {
// Set Chrome factory for mapping BackgroundTask classes to TaskIds.
ChromeBackgroundTaskFactory.setAsDefault();
AppHooks.get().getChimeDelegate().initialize();
if (VersionConstants.CHANNEL == Channel.CANARY) {
GURL.setReportDebugThrowableCallback(
PureJavaExceptionReporter::reportJavaException);
......@@ -143,7 +145,6 @@ public class ChromeApplication extends SplitCompatApplication {
}
BuildInfo.setFirebaseAppId(FirebaseConfig.getFirebaseAppId());
AppHooks.get().getChimeDelegate().initialize();
if (!ContextUtils.isIsolatedProcess()) {
// Incremental install disables process isolation, so things in this block will
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment