Commit 5e35c9c7 authored by Isabella Scalzi's avatar Isabella Scalzi Committed by Commit Bot

Address review nits for CL:1994548

Bug: 1038799
Change-Id: Ia5f917405c2eed46fe1d9c07bf110f9f3aac0ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003153Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732330}
parent f22d17dd
...@@ -66,7 +66,7 @@ class QuickViewController { ...@@ -66,7 +66,7 @@ class QuickViewController {
this.entries_ = []; this.entries_ = [];
/** /**
* The current selection when in check-select mode. * The current selection index of this.entries_.
* @private {number} * @private {number}
*/ */
this.currentSelection_ = 0; this.currentSelection_ = 0;
...@@ -197,7 +197,10 @@ class QuickViewController { ...@@ -197,7 +197,10 @@ class QuickViewController {
} }
/** /**
* Changes the currently selected in single-select mode. * Changes the currently selected entry when in single-select mode. Sets
* the models |selectedIndex| to indirectly trigger onFileSelectionChanged_
* and populate |this.entries_|.
*
* @param {boolean} down True if user pressed down arrow, false if up. * @param {boolean} down True if user pressed down arrow, false if up.
* @private * @private
*/ */
...@@ -220,8 +223,8 @@ class QuickViewController { ...@@ -220,8 +223,8 @@ class QuickViewController {
} }
/** /**
* Changes the currently selected in multi-select mode (aka what the file * Changes the currently selected entry when in multi-select mode (file
* list calls "check-select" mode). * list calls this "check-select" mode).
* *
* @param {boolean} down True if user pressed down arrow, false if up. * @param {boolean} down True if user pressed down arrow, false if up.
* @private * @private
...@@ -252,7 +255,7 @@ class QuickViewController { ...@@ -252,7 +255,7 @@ class QuickViewController {
* @private * @private
*/ */
display_(wayToOpen) { display_(wayToOpen) {
// On opening, always initalise the single-select mode selection. // On opening Quick View, always reset the current selection index.
this.currentSelection_ = 0; this.currentSelection_ = 0;
this.updateQuickView_().then(() => { this.updateQuickView_().then(() => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment