Commit 5e40eec4 authored by Sorin Jianu's avatar Sorin Jianu Committed by Commit Bot

Revert "mac: Re-enable PageInfoBubbleViewsMacTest."

This reverts commit 23d3d537.

Reason for revert: It breaks tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests such as

failures:
PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/1
PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/0

10.12 is affected too:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15611

Original change's description:
> mac: Re-enable PageInfoBubbleViewsMacTest.
> 
> Bug: 845389
> Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4
> Reviewed-on: https://chromium-review.googlesource.com/c/1258293
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596204}

TBR=ellyjones@chromium.org,thakis@chromium.org

Change-Id: Ied439ffdb5cce7d708c250251d74a8d2c9b98631
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845389
Reviewed-on: https://chromium-review.googlesource.com/c/1259143Reviewed-by: default avatarSorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596251}
parent 04f0a9e5
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#import "chrome/browser/ui/page_info/page_info_dialog.h" #import "chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
...@@ -25,6 +25,11 @@ ...@@ -25,6 +25,11 @@
#include "ui/views/widget/widget.h" #include "ui/views/widget/widget.h"
#include "url/url_constants.h" #include "url/url_constants.h"
@interface PageInfoBubbleController (ExposedForTesting)
+ (PageInfoBubbleController*)getPageInfoBubbleForTest;
- (void)performLayout;
@end
namespace { namespace {
struct GURLBubbleTypePair { struct GURLBubbleTypePair {
......
...@@ -1929,7 +1929,6 @@ test("browser_tests") { ...@@ -1929,7 +1929,6 @@ test("browser_tests") {
"../browser/ui/cocoa/applescript/window_applescript_test.mm", "../browser/ui/cocoa/applescript/window_applescript_test.mm",
"../browser/ui/cocoa/browser_window_mac_browsertest.mm", "../browser/ui/cocoa/browser_window_mac_browsertest.mm",
"../browser/ui/cocoa/certificate_viewer_mac_browsertest.mm", "../browser/ui/cocoa/certificate_viewer_mac_browsertest.mm",
"../browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm",
"../browser/ui/cocoa/share_menu_controller_browsertest.mm", "../browser/ui/cocoa/share_menu_controller_browsertest.mm",
"../browser/ui/cocoa/task_manager_mac_browsertest.mm", "../browser/ui/cocoa/task_manager_mac_browsertest.mm",
] ]
...@@ -1970,6 +1969,7 @@ test("browser_tests") { ...@@ -1970,6 +1969,7 @@ test("browser_tests") {
## TODO(crbug/845389): Re-Enable the following, which were temporarily ## TODO(crbug/845389): Re-Enable the following, which were temporarily
## omitted from the build, but still in use by the Cocoa browser. ## omitted from the build, but still in use by the Cocoa browser.
# "../browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm", # "../browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm",
# "../browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm",
] ]
} }
if (is_win) { if (is_win) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment