Commit 5e4c7d7b authored by Siddhartha's avatar Siddhartha Committed by Commit Bot

Fix conditions for can_unwind_with_cfi_table with frame pointers

CFI table unwinder is not appilcable for builds with frame pointer
enabled. Make sure can_unwind_with_cfi_table is set to false.
No need to check for use_thin_lto.

BUG=469376

Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6
Reviewed-on: https://chromium-review.googlesource.com/992890Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548634}
parent 5e14b627
......@@ -143,11 +143,8 @@ assert(!can_unwind_with_frame_pointers || enable_frame_pointers)
# Unwinding with CFI table is only possible on static library builds and
# requried only when frame pointers are not enabled.
# Builds with use_thin_lto use link registers to store offsets, and this is
# not supported yet.
can_unwind_with_cfi_table =
is_android && !is_component_build && !can_unwind_with_frame_pointers &&
current_cpu == "arm" && !use_thin_lto
can_unwind_with_cfi_table = is_android && !is_component_build &&
!enable_frame_pointers && current_cpu == "arm"
declare_args() {
# Whether or not the official builds should be built with full WPO. Enabled by
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment