Remove unnecessary uses of source_is_generated from //chrome

This will let GN validate that deps are not missed.
Note: deps->public_deps needed in order to appease GN's
"do you depend on the targets that produce your inputs"
check (you can directly depend on them, or indirectly
when listed as public_deps).

Bug: 1054892
Change-Id: I25ee07e95cf7744428c95cc19141b3ab4c0d5bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090030Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748358}

chrome/browser/BUILD.gn

@@ -5528,7 +5528,7 @@ proto_library("permissions_proto") {
 grit("resources") {
   source = "browser_resources.grd"
 
-  # The .grd contains references to generated files.
+  # Required due to flattenhtml="true" on a generated file.
   source_is_generated = true
 
   use_brotli = true
@@ -5643,9 +5643,6 @@ if (is_chrome_branded) {
 grit("dev_ui_browser_resources") {
   source = "dev_ui_browser_resources.grd"
 
-  # The .grd contains references to generated files.
-  source_is_generated = true
-
   defines = chrome_grit_defines
 
   output_dir = "$root_gen_dir/chrome"

chrome/browser/resources/bluetooth_internals/BUILD.gn

@@ -69,8 +69,6 @@ js_library("page_manager") {
 grit("resources") {
   source = "resources.grd"
 
-  # The .grd contains references to generated files.
-  source_is_generated = true
   outputs = [
     "grit/bluetooth_internals_resources.h",
     "grit/bluetooth_internals_resources_map.h",

chrome/browser/resources/bookmarks/BUILD.gn

@@ -35,8 +35,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "bookmarks_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
     grit_flags = [
       "-E",
       "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
@@ -55,7 +53,7 @@ if (optimize_webui) {
 }
 
 group("polymer3_elements") {
-  deps = [
+  public_deps = [
     ":app_module",
     ":command_manager_module",
     ":edit_dialog_module",

chrome/browser/resources/chromeos/BUILD.gn

@@ -51,9 +51,6 @@ grit("camera_resources") {
     "//media/capture/video/chromeos/mojom:cros_camera_js",
   ]
 
-  # The .grd contains references to generated files.
-  source_is_generated = true
-
   grit_flags = [
     "-E",
     "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),

chrome/browser/resources/downloads/BUILD.gn

@@ -39,9 +39,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "downloads_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
-
     defines = chrome_grit_defines
     outputs = [
       "grit/downloads_resources.h",
@@ -147,7 +144,7 @@ js_library("toolbar") {
 }
 
 group("polymer3_elements") {
-  deps = [
+  public_deps = [
     ":icons_module",
     ":item_module",
     ":manager_module",

chrome/browser/resources/extensions/BUILD.gn

@@ -35,8 +35,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "extensions_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
     grit_flags = [
       "-E",
       "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
@@ -62,7 +60,7 @@ group("closure_compile") {
 }
 
 group("polymer3_elements") {
-  deps = [
+  public_deps = [
     ":checkup_module",
     ":code_section_module",
     ":detail_view_module",
@@ -90,7 +88,7 @@ group("polymer3_elements") {
     "activity_log:polymer3_elements",
   ]
   if (is_chromeos) {
-    deps += [ ":kiosk_dialog_module" ]
+    public_deps += [ ":kiosk_dialog_module" ]
   }
 }
 

chrome/browser/resources/extensions/activity_log/BUILD.gn

@@ -36,7 +36,7 @@ polymer_modulizer("activity_log_stream_item") {
 }
 
 group("polymer3_elements") {
-  deps = [
+  public_deps = [
     ":activity_log_history_item_module",
     ":activity_log_history_module",
     ":activity_log_module",

chrome/browser/resources/history/BUILD.gn

@@ -42,8 +42,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "history_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
     grit_flags = [
       "-E",
       "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
@@ -216,7 +214,7 @@ js_library("synced_device_manager") {
 }
 
 group("polymer3_elements") {
-  deps = [
+  public_deps = [
     ":app_module",
     ":history_item_module",
     ":history_list_module",

chrome/browser/resources/media/BUILD.gn

@@ -7,8 +7,6 @@ import("//tools/grit/grit_rule.gni")
 grit("webrtc_logs_resources") {
   source = "webrtc_logs_resources.grd"
 
-  # The .grd contains references to generated files.
-  source_is_generated = true
   use_brotli = true
   outputs = [
     "grit/webrtc_logs_resources.h",

chrome/browser/resources/omnibox/BUILD.gn

@@ -53,8 +53,6 @@ js_library("omnibox_popup") {
 grit("resources") {
   source = "resources.grd"
 
-  # The .grd contains references to generated files.
-  source_is_generated = true
   outputs = [
     "grit/omnibox_resources.h",
     "omnibox_resources.pak",

chrome/browser/resources/print_preview/BUILD.gn

@@ -38,8 +38,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "print_preview_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
     grit_flags = [
       "-E",
       "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),

chrome/browser/resources/print_preview/ui/BUILD.gn

@@ -483,7 +483,7 @@ js_library("highlight_utils") {
 }
 
 group("polymer3_elements") {
-  deps = [
+  public_deps = [
     ":advanced_options_settings_module",
     ":advanced_settings_dialog_module",
     ":advanced_settings_item_module",

chrome/browser/resources/settings/BUILD.gn

@@ -59,8 +59,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "settings_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
     grit_flags = [
       "-E",
       "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),

chrome/browser/resources/settings/chromeos/BUILD.gn

@@ -55,9 +55,6 @@ if (optimize_webui) {
   grit("flattened_resources") {
     source = "../os_settings_resources.grd"
 
-    # The .grd contains references to generated files.
-    source_is_generated = true
-
     defines = chrome_grit_defines
     outputs = [
       "grit/os_settings_resources.h",

chrome/chrome_cleaner/test/resources/BUILD.gn

@@ -36,9 +36,6 @@ grit("test_resources") {
   source = "test_resources.grd"
   resource_ids = "resource_ids"
 
-  # The .grd contains references to generated files.
-  source_is_generated = true
-
   outputs = [
     "grit/test_resources.h",
     "test_resources.rc",