Skip to content

GitLab

T
tangled
Commit 5e7bb6d9 authored by Yoshifumi Inoue's avatar Yoshifumi Inoue Committed by Commit Bot
Browse files
Options

Utilize selection_test() in editing/deleting/delete-3608430-fix.html 

This patch changes "editing/deleting/delete-3608430-fix.html" to utilize
|selection_test()| for ease of maintenance.

This patch also makes the test independent from trailing space handling for
preparation of migrating to EditingNG.

Note: legacy layout keep trailing spaces in |InlineTextBox| but LayoutNG not.

Bug: 707656, 679977
Change-Id: I8a54875576f9cc76d9a5873ee995a93a77fd1f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166241
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762749}
parent 46773a98
Hide whitespace changes
Inline Side-by-side
Showing with 15 additions and 69 deletions
third_party/blink/web_tests/editing/deleting/delete-3608430-fix-expected.txt deleted 100644 → 0
View file @ 46773a98
This test makes sure that deletion of an element auto-removes a blank element before it. Below, you should see "start-deleting", followed by several lines showing the states of the content-editable div over time, ending with 'start-deleting' inside a span id'd as "test".
start-deleting
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-me-andstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-me-anstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-me-astart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-me-start-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-mestart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-mstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-in-start-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-instart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-istart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> select-start-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> selectstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> selecstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> selestart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> selstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> sestart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png"> sstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png">&nbsp;start-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo <i> </i> <img src="../resources/abe.png">start-deleting</span>
execDeleteCommand: <span id="test">foo <br>foo start-deleting</span>
execDeleteCommand: <span id="test">foo <br>foostart-deleting</span>
execDeleteCommand: <span id="test">foo <br>fostart-deleting</span>
execDeleteCommand: <span id="test">foo <br>fstart-deleting</span>
execDeleteCommand: <span id="test">foo <br>start-deleting</span>
execDeleteCommand: <span id="test">foo start-deleting</span>
execDeleteCommand: <span id="test">foostart-deleting</span>
execDeleteCommand: <span id="test">fostart-deleting</span>
execDeleteCommand: <span id="test">fstart-deleting</span>
execDeleteCommand: <span id="test">start-deleting</span>
third_party/blink/web_tests/editing/deleting/delete-3608430-fix.html
View file @ 5e7bb6d9
<!DOCTYPE html>
<html>
<head>
<style>
.editing {
border: 2px solid red;
padding: 12px;
font-size: 24px;
}
</style>
<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../assert_selection.js"></script>
<script>
function editingTest() {
for (i = 0; i < 28; i++) {
moveSelectionForwardByCharacterCommand();
}
for (i = 0; i < 28; i++) {
deleteCommand();
}
}
// This test makes sure that deletion of an element auto-removes a blank element
// before it.
selection_test(
'<div contenteditable>ab <i> </i> <img src="../resources/abe.png">|',
'delete',
'<div contenteditable>ab\u00A0|</div>',
'A space in <i> is collapsed.');
selection_test(
'<div contenteditable>ab<i> </i> <img src="../resources/abe.png">|',
'delete',
'<div contenteditable>ab<i>\u00A0|</i></div>',
'A space in <i> is not collapsed.');
</script>
<title>Editing Test</title>
</head>
<body>
<p>This test makes sure that deletion of an element auto-removes a blank element before it. Below, you should see "start-deleting", followed by several lines showing the states of the content-editable div over time, ending with 'start-deleting' inside a span id'd as "test".</p>
<div contenteditable id="root" class="editing">
<span id="test">foo
<br>foo <i> </i> <img src="../resources/abe.png"> select-in-me-and-start-deleting</span>
</div>
<script>
runDumpAsTextEditingTest();
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment